rtld: add some dlopen tests
ClosedPublic
Actions

Authored by kevans on Feb 13 2024, 2:31 AM.

Details

Reviewers

kib
bdrewery

Commits

rGc5796f1572c8: rtld: add some dlopen tests

Summary

dlopen_basic just tests that libthr.so can be dlopen()ed, which will
just serve as a sanity check that "libthr.so" is a thing that can be
dlopened in case we get a weird failure in dlopen_recursing.

dlopen_recursing tests a regression reported after the libsys split,
where some dlopen() may cause infinite recursion and a resulting crash.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55976
Build 52865: arc lint + arc unit

Event Timeline

kevans created this revision.Feb 13 2024, 2:31 AM

Herald added subscribers: bdragon, imp. · View Herald TranscriptFeb 13 2024, 2:31 AM

kevans requested review of this revision.Feb 13 2024, 2:31 AM

Harbormaster completed remote builds in B55976: Diff 134234.Feb 13 2024, 2:31 AM

kevans mentioned this in D43858: More avoidance of the filtees loading recursion.Feb 13 2024, 2:31 AM

How fresh are processes where ATF executes tests? Would both dlopen_basic and dlopen_recursing execute in the same image sequentially, or ATF spawns/execs a new process to run each test?

In D43859#1000568, @kib wrote:

How fresh are processes where ATF executes tests? Would both dlopen_basic and dlopen_recursing execute in the same image sequentially, or ATF spawns/execs a new process to run each test?

Each individual test case within a program will always be executed in a fresh image -- ATF doesn't have any way to request multiple tests in a single execution of the test program

kib accepted this revision.Feb 13 2024, 4:08 AM

This revision is now accepted and ready to land.Feb 13 2024, 4:08 AM

Closed by commit rGc5796f1572c8: rtld: add some dlopen tests (authored by kevans). · Explain WhyFeb 13 2024, 3:39 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rGc5796f1572c8: rtld: add some dlopen tests.