Differential D43852

tests/unix_seqpacket: provide function that returns bound & listening sock
ClosedPublic
Actions

Authored by glebius on Feb 12 2024, 7:55 PM.

Tags

None

Referenced Files

	F144761864: D43852.id134226.diff
	Thu, Feb 12, 6:59 AM

	Unknown Object (File)
	Sun, Feb 8, 3:12 PM

	Unknown Object (File)
	Sun, Feb 8, 2:28 PM

	Unknown Object (File)
	Sat, Feb 7, 11:24 PM

	Unknown Object (File)
	Sat, Jan 31, 4:39 AM

	Unknown Object (File)
	Mon, Jan 26, 2:47 AM

	Unknown Object (File)
	Sun, Jan 25, 1:21 AM

	Unknown Object (File)
	Wed, Jan 14, 5:57 AM

Subscribers

Details

Reviewers

asomers
tuexen

Group Reviewers

Commits

rG1f46c32c1f3d: tests/unix_seqpacket: provide function that returns bound & listening sock

Summary

Use the function in mk_pair_of_sockets(), and in two tests -
'listen_bound' and 'connect'. While here make mk_pair_of_sockets() return
pointer to sockaddr_un instead of path. This also fixes bug of returning
pointer to stack memory of returning function. However, the only caller
that cares about this return is temporarily ifdefed out. No functional
changes intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55968
Build 52857: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 12 2024, 7:55 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 12 2024, 7:55 PM

glebius requested review of this revision.Feb 12 2024, 7:55 PM

Harbormaster completed remote builds in B55968: Diff 134221.Feb 12 2024, 7:55 PM

glebius added a child revision: D43853: tests/unix_seqpacket: test that data can be sent before accept(2).Feb 12 2024, 7:55 PM

Couple more places to use the new function.

Harbormaster completed remote builds in B55972: Diff 134226.Feb 12 2024, 8:39 PM

tuexen accepted this revision.Feb 12 2024, 9:30 PM

This revision is now accepted and ready to land.Feb 12 2024, 9:30 PM

Closed by commit rG1f46c32c1f3d: tests/unix_seqpacket: provide function that returns bound & listening sock (authored by glebius). · Explain WhyFeb 28 2024, 10:33 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG1f46c32c1f3d: tests/unix_seqpacket: provide function that returns bound & listening sock.

Revision Contents
Changeset List

Path

Size

tests/

sys/

kern/

unix_seqpacket_test.c

97 lines

Diff 134221

tests/sys/kern/unix_seqpacket_test.c

Loading...