Page MenuHomeFreeBSD
Differential D43715

ctfmerge: remove function cast of strcompare() for qsort()
ClosedPublic
Actions

Authored by mchoo on Feb 2 2024, 10:12 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Aug 12, 9:32 PM
Unknown Object (File)
Wed, Aug 12, 8:56 PM
Unknown Object (File)
Wed, Aug 12, 7:14 PM
Unknown Object (File)
Wed, Aug 12, 8:23 AM
Unknown Object (File)
Tue, Aug 11, 4:30 PM
Unknown Object (File)
Tue, Aug 11, 4:30 PM
Unknown Object (File)
Tue, Aug 11, 4:30 PM
Unknown Object (File)
Mon, Aug 10, 11:07 AM
View All Files
Subscribers
imp
markj
Contributor Reviews (src)

Details

Reviewers
emaste
Group Reviewers
Contributor Reviews (src)
Commits
rGac5b3cba91f9: ctfmerge: Remove function cast of strcompare() for qsort()
rGf73124b077d8: ctfmerge: Remove function cast of strcompare() for qsort()
Summary

qsort(tifiles, nifiles, sizeof (char *), strcompare); also works.

Test Plan

make buildworld

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 55770
Build 52659: arc lint + arc unit

Event Timeline

mchoo created this revision.Feb 2 2024, 10:12 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2024, 10:12 PM
mchoo requested review of this revision.Feb 2 2024, 10:12 PM
Harbormaster completed remote builds in B55766: Diff 133768.Feb 2 2024, 10:12 PM
mchoo edited the summary of this revision. (Show Details)Feb 2 2024, 10:12 PM
mchoo added a reviewer: Contributor Reviews (src).Feb 3 2024, 2:13 AM
mchoo added a project: Contributor Reviews (src).
mchoo added a subscriber: Contributor Reviews (src).
markj added a subscriber: markj.Feb 3 2024, 2:32 AM

qsort(tifiles, nifiles, sizeof (char *), strcompare); also works.

If we can just get rid of the cast, and it looks like we can, then let's do that.

mchoo updated this revision to Diff 133780.Feb 3 2024, 2:50 AM

Remove cast to function pointer

Harbormaster completed remote builds in B55769: Diff 133780.Feb 3 2024, 2:51 AM
mchoo retitled this revision from ctfmerge: specify parameter types of strcompare() for qsort() to ctfmerge: remove function cast of strcompare() for qsort().Feb 3 2024, 2:55 AM
mchoo updated this revision to Diff 133781.Feb 3 2024, 2:57 AM

Updated commit message

Harbormaster completed remote builds in B55770: Diff 133781.Feb 3 2024, 2:57 AM
emaste accepted this revision.Feb 3 2024, 3:09 AM
This revision is now accepted and ready to land.Feb 3 2024, 3:09 AM
Closed by commit rGf73124b077d8: ctfmerge: Remove function cast of strcompare() for qsort() (authored by mchoo, committed by markj). · Explain WhyFeb 3 2024, 7:10 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGf73124b077d8: ctfmerge: Remove function cast of strcompare() for qsort().
markj added a commit: rGac5b3cba91f9: ctfmerge: Remove function cast of strcompare() for qsort().Feb 11 2024, 3:17 PM

Revision Contents
Changeset List

PathSize
cddl/
contrib/
opensolaris/
tools/
ctf/
cvt/
2 lines

Diff 133781

View Options

cddl/contrib/opensolaris/tools/ctf/cvt/ctfmerge.c

Loading...