Page MenuHomeFreeBSD
Differential D43695

ddb: Use bool for boolean variables in MD code
ClosedPublic
Actions

Authored by jhb on Jan 31 2024, 11:33 PM.
Tags
None
Referenced Files
F101735880: D43695.id133679.diff
Sun, Nov 3, 12:51 AM
Unknown Object (File)
Sun, Oct 27, 8:31 AM
Unknown Object (File)
Fri, Oct 25, 8:28 AM
Unknown Object (File)
Tue, Oct 8, 12:33 PM
Unknown Object (File)
Sat, Oct 5, 11:56 AM
Unknown Object (File)
Fri, Oct 4, 7:34 PM
Unknown Object (File)
Oct 3 2024, 9:50 PM
Unknown Object (File)
Oct 3 2024, 7:09 AM
View All 49 Files
Subscribers
imp
jhibbits

Details

Reviewers
markj
Commits
rG1027e838a8ee: ddb: Use bool for boolean variables in MD code

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 55742
Build 52631: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 31 2024, 11:33 PM
Herald added subscribers: jhibbits, imp. · View Herald TranscriptJan 31 2024, 11:33 PM
jhb requested review of this revision.Jan 31 2024, 11:33 PM
Harbormaster completed remote builds in B55742: Diff 133679.Jan 31 2024, 11:33 PM
jhb added a parent revision: D43694: arm: pmap_extract() returns a PA not a boolean value.Jan 31 2024, 11:33 PM
markj accepted this revision.Feb 1 2024, 2:05 PM
markj added inline comments.
sys/amd64/amd64/db_disasm.c
1046

short_addr should also be a bool.

1510
1512
1521
sys/i386/i386/db_disasm.c
939
1226
This revision is now accepted and ready to land.Feb 1 2024, 2:05 PM
jhb marked 6 inline comments as done.Feb 2 2024, 11:04 PM

Nice catches

Closed by commit rG1027e838a8ee: ddb: Use bool for boolean variables in MD code (authored by jhb). · Explain WhyFeb 2 2024, 11:09 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG1027e838a8ee: ddb: Use bool for boolean variables in MD code.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
1152 lines
20 lines
i386/
i386/
1026 lines
powerpc/
powerpc/
10 lines

Diff 133679

View Options

sys/amd64/amd64/db_disasm.c

Loading...
View Options

sys/amd64/amd64/db_trace.c

Loading...
View Options

sys/i386/i386/db_disasm.c

Loading...
View Options

sys/powerpc/powerpc/db_trace.c

Loading...