Page MenuHomeFreeBSD
Differential D43454

multimedia/mkvtoolnix: Subpackage'ify
Needs ReviewPublic
Actions

Authored by riggs on Jan 14 2024, 6:58 PM.
Tags
None
Referenced Files
F122512898: D43454.id133478.diff
Sat, Jul 5, 9:53 PM
F122436708: D43454.id132765.diff
Sat, Jul 5, 8:23 AM
Unknown Object (File)
Fri, Jul 4, 9:19 PM
Unknown Object (File)
Thu, Jul 3, 11:52 PM
Unknown Object (File)
Mon, Jun 30, 11:26 AM
Unknown Object (File)
Sun, Jun 29, 6:37 PM
Unknown Object (File)
Sun, Jun 29, 1:51 AM
Unknown Object (File)
Sat, Jun 28, 7:18 PM
View All Files
Subscribers
eduardo
mat

Details

Reviewers
mat
Group Reviewers
portmgr

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

riggs requested review of this revision.Jan 14 2024, 6:58 PM
riggs created this revision.
riggs added a reviewer: portmgr.
mat added a subscriber: mat.Jan 14 2024, 8:53 PM

This looks ok to me, but with the missing context, it's a bit hard to see if it could be made even better.

riggs updated this revision to Diff 132765.Jan 14 2024, 9:20 PM
riggs updated this revision to Diff 132815.Jan 16 2024, 8:39 AM
mat added a comment.Jan 16 2024, 8:44 AM

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

eduardo added a subscriber: eduardo.Jan 18 2024, 11:47 PM
riggs updated this revision to Diff 133118.Jan 21 2024, 5:54 PM
In D43454#990804, @mat wrote:

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

Added a proposal for this.

mat requested changes to this revision.Jan 21 2024, 6:39 PM

The guimantrans seems to be a bit overboard, just put all the translated man pages into mantrans.

This revision now requires changes to proceed.Jan 21 2024, 6:39 PM
riggs updated this revision to Diff 133478.Jan 29 2024, 7:34 AM

Dropped the mantrans subpackages, include translations in main and the gui subpackage.

Revision Contents
Changeset List

PathSize
multimedia/
mkvtoolnix/
38 lines
238 lines

Diff 133478

View Options

multimedia/mkvtoolnix/Makefile

Loading...
View Options

multimedia/mkvtoolnix/pkg-plist

Loading...