Page MenuHomeFreeBSD

multimedia/mkvtoolnix: Subpackage'ify
Needs ReviewPublic

Authored by riggs on Jan 14 2024, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 10, 9:25 AM
Unknown Object (File)
Tue, Dec 2, 12:51 AM
Unknown Object (File)
Fri, Nov 28, 9:04 PM
Unknown Object (File)
Fri, Nov 28, 6:35 PM
Unknown Object (File)
Thu, Nov 27, 1:11 AM
Unknown Object (File)
Fri, Nov 21, 8:00 PM
Unknown Object (File)
Wed, Nov 19, 1:24 PM
Unknown Object (File)
Wed, Nov 19, 9:40 AM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

riggs requested review of this revision.Jan 14 2024, 6:58 PM
riggs created this revision.
riggs added a reviewer: portmgr.

This looks ok to me, but with the missing context, it's a bit hard to see if it could be made even better.

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

In D43454#990804, @mat wrote:

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

Added a proposal for this.

mat requested changes to this revision.Jan 21 2024, 6:39 PM

The guimantrans seems to be a bit overboard, just put all the translated man pages into mantrans.

This revision now requires changes to proceed.Jan 21 2024, 6:39 PM

Dropped the mantrans subpackages, include translations in main and the gui subpackage.