Page MenuHomeFreeBSD

multimedia/mkvtoolnix: Subpackage'ify
Needs ReviewPublic

Authored by riggs on Jan 14 2024, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 4, 2:35 PM
Unknown Object (File)
Thu, Oct 3, 10:51 AM
Unknown Object (File)
Thu, Oct 3, 7:42 AM
Unknown Object (File)
Wed, Oct 2, 2:51 PM
Unknown Object (File)
Wed, Oct 2, 4:48 AM
Unknown Object (File)
Wed, Oct 2, 4:31 AM
Unknown Object (File)
Tue, Oct 1, 8:27 PM
Unknown Object (File)
Tue, Sep 24, 2:24 PM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

riggs requested review of this revision.Jan 14 2024, 6:58 PM
riggs created this revision.
riggs added a reviewer: portmgr.

This looks ok to me, but with the missing context, it's a bit hard to see if it could be made even better.

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

In D43454#990804, @mat wrote:

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

Added a proposal for this.

mat requested changes to this revision.Jan 21 2024, 6:39 PM

The guimantrans seems to be a bit overboard, just put all the translated man pages into mantrans.

This revision now requires changes to proceed.Jan 21 2024, 6:39 PM

Dropped the mantrans subpackages, include translations in main and the gui subpackage.