Page MenuHomeFreeBSD

multimedia/mkvtoolnix: Subpackage'ify
Needs ReviewPublic

Authored by riggs on Jan 14 2024, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 26, 2:59 AM
Unknown Object (File)
Apr 23 2024, 3:34 AM
Unknown Object (File)
Apr 2 2024, 9:02 AM
Unknown Object (File)
Apr 2 2024, 9:00 AM
Unknown Object (File)
Apr 2 2024, 8:57 AM
Unknown Object (File)
Mar 9 2024, 9:04 PM
Unknown Object (File)
Feb 11 2024, 9:17 AM
Unknown Object (File)
Jan 27 2024, 6:03 PM
Subscribers

Details

Reviewers
mat
Group Reviewers
portmgr

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

riggs requested review of this revision.Jan 14 2024, 6:58 PM
riggs created this revision.
riggs added a reviewer: portmgr.

This looks ok to me, but with the missing context, it's a bit hard to see if it could be made even better.

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

In D43454#990804, @mat wrote:

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

Added a proposal for this.

mat requested changes to this revision.Jan 21 2024, 6:39 PM

The guimantrans seems to be a bit overboard, just put all the translated man pages into mantrans.

This revision now requires changes to proceed.Jan 21 2024, 6:39 PM

Dropped the mantrans subpackages, include translations in main and the gui subpackage.