Details

Reviewers

imp
olce

Commits

rGbf4972a48d2e: bsdlabel: add deprecation notice
rGb6f3cced151f: bsdlabel: add deprecation notice

Summary

BSD disk labels should be avoided on new installations.

There is no concrete plan to remove BSD label support from FreeBSD but
that will happen at some point in the future.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jan 23 2024, 6:07 PM

emaste created this revision.

I might want to deprecate and remove bsdlabel first, due to PR276517 - BSD label manipulation via gpart does not have the same issue.

Make the deprecation notice for bsdlabel explicit. Also remove comment about legacy-ness of MBR/BSD disklabels, this man page isn't the right place for such a note, and there's work to do elsewhere first (e.g. having a stronger preference for not-MBR/bsdlabel in the installer).

Bsdlabel, the program, was supposed to be completely replaced by gpart, etc so this shouldn't be a surprise.

This revision is now accepted and ready to land.Jan 24 2024, 4:47 PM

olce accepted this revision.Jan 24 2024, 5:26 PM

I'll go ahead and provide a port for the bsdlabel utility so it remains available for legacy use cases.

In D43563#993865, @fuz wrote:

I'll go ahead and provide a port for the bsdlabel utility so it remains available for legacy use cases.

Thanks -- I will not disconnect or remove it before that's done.

First point, a manpage addition is pointless unless you have the binary emit a warning when invoked. Second how does one execute bsdlabel -e -A with gpart?

In D43563#993887, @rgrimes wrote:

First point, a manpage addition is pointless unless you have the binary emit a warning when invoked.

Sure, that can be added too, perhaps as a subsequent commit.

Second how does one execute bsdlabel -e -A with gpart?

One doesn't - one would need to install the port that @fuz will create.

Add reference to newly created freebsd-bsdlabel package

This revision now requires review to proceed.Jan 26 2024, 2:15 PM

Mention BSD partitioning scheme - what gpart uses to refer to BSD disklabels

DEPRECATION NOTICE
bsdlabel is deprecated and is not available in FreeBSD 15.0 or later. Use gpart(8) instead (with the BSD partitioning scheme), or install the freebsd-bsdlabel port or package.

emaste mentioned this in D43586: bsdlabel: emit deprecation notice when run.Jan 26 2024, 3:11 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 25 2024, 7:44 PM

Closed by commit rGb6f3cced151f: bsdlabel: add deprecation notice (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGb6f3cced151f: bsdlabel: add deprecation notice.

emaste added a commit: rGbf4972a48d2e: bsdlabel: add deprecation notice.Apr 16 2024, 1:59 PM