Proposed commit log
net/svnup: Fix linking correct libssl - Use bsd.openssl.mk defined variable for libs Reviewed_by: koobs (mentor), feld (mentor) Approved by: (mentor) Differential_Revision: D4843
Details
Details
- Reviewers
koobs feld - Commits
- rP408876: net/svnup: Fix linking correct libssl
- portlint -AC (no change)
- poudriere testport OK
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 2492 Build 2509: arc lint + arc unit
Event Timeline
Comment Actions
Maintainer contacted via email.
Hi John,
I've just opened a review for net/svnup. Please find it at https://reviews.freebsd.org/D4843 As there's no "maintainer approval" feature in Phabricator, I'm contacting you via mail.
Basically a trivial change that uses the ports framework to link to the OpenSSL libs required by the user via WITH_OPENSSL_PORT=yes and OPENSSL_PORT= security/{open,libre}ssl
With kind regards,
Bernard.
PS. Kubilay and Mark cc-ed as mentors
| net/svnup/Makefile | ||
|---|---|---|
| 17–18 | It looks like both LIBS and LDFLAGS are used for -L and -l in ports. I don't know which one is best. | |
Comment Actions
I believe what this is trying to address, though, is respecting a library choice between BASE vs. PORT/PKG throughout the build process. The way it is now, I don't believe that is accomplished.
| net/svnup/Makefile | ||
|---|---|---|
| 5 | Bump PORTREVISION, since the port is not broken at the moment, and package will change depending on environment / user configuration settings | |
| 17–18 | @brnrd Can you test / tell us the difference between using LDFLAGS and LIBS for this port please. I know some 'autoconf' based software do/supports things slightly differently Also, Does -I need be added here to account for the different include paths depending on whether ports/base openssl is used? | |
| net/svnup/Makefile | ||
|---|---|---|
| 5 | Fixed locally, will appear with next arc update | |
| 17–18 | Learned something again. Libs go into LIBS, Linker flags into LDFLAGS. I've tried long and hard but it seems it will NOT build unless this is all placed in LDFLAGS. LIBS= -lmd -lssl
LDFLAGS= -L${OPENSSLLIB}
===> Building for svnup-1.07_2
cd /usr/ports/net/svnup/work/svnup-1.07 && cc -o svnup -O2 -fno-strict-aliasing -pipe -march=native -fstack-protector svnup.c -L/usr/local/lib -Wl,-rpath,/usr/local/lib -fstack-protector
svnup.c:37:10: fatal error: 'openssl/ssl.h' file not found
#include <openssl/ssl.h>This is a result of a base system with Private SSL libs CFLAGS= -I${OPENSSLINC}
LIBS= -lmd -lssl
LDFLAGS= -L${OPENSSLLIB}
===> Building for svnup-1.07_2
cd /usr/ports/net/svnup/work/svnup-1.07 && cc -o svnup -I/usr/local/include -fstack-protector -fno-strict-aliasing svnup.c -L/usr/local/lib -Wl,-rpath,/usr/local/lib -fstack-protector
/tmp/svnup-195845.o: In function `main':
svnup.c:(.text+0x4dcc): undefined reference to `SSL_shutdown'
svnup.c:(.text+0x4dde): undefined reference to `SSL_CTX_free'
svnup.c:(.text+0x4dea): undefined reference to `SSL_free'
/tmp/svnup-195845.o: In function `reset_connection':
svnup.c:(.text+0x58d2): undefined reference to `SSL_library_init'
svnup.c:(.text+0x58f6): undefined reference to `SSL_load_error_strings'
svnup.c:(.text+0x58fb): undefined reference to `SSLv23_client_method'
svnup.c:(.text+0x5903): undefined reference to `SSL_CTX_new'
svnup.c:(.text+0x5931): undefined reference to `SSL_CTX_ctrl'
svnup.c:(.text+0x595e): undefined reference to `SSL_CTX_ctrl'
svnup.c:(.text+0x5972): undefined reference to `SSL_new'
svnup.c:(.text+0x59ad): undefined reference to `SSL_set_fd'
svnup.c:(.text+0x59c0): undefined reference to `SSL_connect'
svnup.c:(.text+0x59f0): undefined reference to `SSL_get_error'
/tmp/svnup-195845.o: In function `process_command_http':
svnup.c:(.text+0x64d4): undefined reference to `SSL_read'
/tmp/svnup-195845.o: In function `confirm_md5':
svnup.c:(.text+0x7d61): undefined reference to `MD5Init'
svnup.c:(.text+0x7da2): undefined reference to `MD5Update'
svnup.c:(.text+0x7db5): undefined reference to `MD5End'
svnup.c:(.text+0x7f33): undefined reference to `MD5Init'
svnup.c:(.text+0x7f4e): undefined reference to `MD5Update'
svnup.c:(.text+0x7f61): undefined reference to `MD5End'
/tmp/svnup-195845.o: In function `get_files':
svnup.c:(.text+0x9205): undefined reference to `MD5Init'
svnup.c:(.text+0x922d): undefined reference to `MD5Update'
svnup.c:(.text+0x9243): undefined reference to `MD5End'
/tmp/svnup-195845.o: In function `send_command':
svnup.c:(.text+0xa5fb): undefined reference to `SSL_write'
cc: error: linker command failed with exit code 1 (use -v to see invocation)This only works like this CFLAGS= -I${OPENSSLINC}
LDFLAGS= -L${OPENSSLLIB} -lmd -lssl
===> Building for svnup-1.07_2
cd /usr/ports/net/svnup/work/svnup-1.07 && cc -o svnup -I/usr/local/include -fstack-protector -fno-strict-aliasing svnup.c -L/usr/local/lib -lmd -lssl -Wl,-rpath,/usr/local/lib -fstack-protector
===> Staging for svnup-1.07_2 etcThe patch will be updated shortly to honor base/ports OpenSSL | |