Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
snd_uaudio(4) is declared as "uaudio" instead of "snd_uaudio" for some reason. We might want to change this.
sys/dev/sound/driver.c | ||
---|---|---|
80 | it's curious that uaudio didn't follow the convention |
We might want to change this.
Our comments crossed paths :)
The module is KMOD= snd_uaudio and it makes sense to me to switch this over in a subsequent change
Does this have any user-visible effects? I'd guess not since sound(4) is compiled into GENERIC on most platforms, but I'm not sure.
Hrm, with the uaudio driver being loaded by USB on demand I suspect we don't want the MODULE_DEPEND(snd_driver, uaudio, 1, 1, 1);?
It's a little odd that we load all these for this driver. It seems a bit backwards...
However, making sure the list is complete and we can defer dealing with that issue for now.
We technically don't need it, but I kept it here for completeness.
But does this mean that snd_uaudio will get loaded as a dependency of sound.ko rather than on demand after USB plug?