Page MenuHomeFreeBSD
Differential D43394

sound: add missing modules to snd_driver
ClosedPublic
Actions

Authored by christos on Jan 10 2024, 9:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 7 2024, 4:20 AM
Unknown Object (File)
Apr 27 2024, 12:50 PM
Unknown Object (File)
Apr 27 2024, 12:50 PM
Unknown Object (File)
Apr 27 2024, 12:50 PM
Unknown Object (File)
Apr 27 2024, 12:10 PM
Unknown Object (File)
Apr 27 2024, 12:10 PM
Unknown Object (File)
Apr 27 2024, 11:40 AM
Unknown Object (File)
Feb 14 2024, 9:33 AM
View All 12 Files
Subscribers
imp

Details

Reviewers
markj
emaste
imp
Commits
rGf7db1b3d7bbf: sound: add missing modules to snd_driver
rG3a79c3ac8aa3: sound: add missing modules to snd_driver
Summary

Sponsored by: The FreeBSD Foundation
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jan 10 2024, 9:04 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 10 2024, 9:04 PM
christos requested review of this revision.Jan 10 2024, 9:04 PM
Harbormaster completed remote builds in B55355: Diff 132568.Jan 10 2024, 9:05 PM
christos updated this revision to Diff 132569.Jan 10 2024, 9:21 PM
  • Remove useless break while at it.
  • s/snd_uaudio/uaudio/
Harbormaster completed remote builds in B55356: Diff 132569.Jan 10 2024, 9:21 PM
christos added a reviewer: emaste.Jan 10 2024, 9:31 PM
christos added a comment.Jan 10 2024, 9:47 PM

snd_uaudio(4) is declared as "uaudio" instead of "snd_uaudio" for some reason. We might want to change this.

emaste accepted this revision.Jan 10 2024, 9:49 PM
emaste added inline comments.
sys/dev/sound/driver.c
80

it's curious that uaudio didn't follow the convention

This revision is now accepted and ready to land.Jan 10 2024, 9:49 PM
emaste added a comment.Jan 10 2024, 9:50 PM

We might want to change this.

Our comments crossed paths :)

The module is KMOD= snd_uaudio and it makes sense to me to switch this over in a subsequent change

markj added a comment.Jan 10 2024, 10:09 PM

Does this have any user-visible effects? I'd guess not since sound(4) is compiled into GENERIC on most platforms, but I'm not sure.

christos added a comment.Jan 10 2024, 10:16 PM
In D43394#989274, @markj wrote:

Does this have any user-visible effects? I'd guess not since sound(4) is compiled into GENERIC on most platforms, but I'm not sure.

Probably not, but the list is still incomplete.

emaste added a comment.Jan 10 2024, 10:29 PM

Hrm, with the uaudio driver being loaded by USB on demand I suspect we don't want the MODULE_DEPEND(snd_driver, uaudio, 1, 1, 1);?

christos marked an inline comment as done.Jan 10 2024, 10:34 PM
In D43394#989279, @emaste wrote:

Hrm, with the uaudio driver being loaded by USB on demand I suspect we don't want the MODULE_DEPEND(snd_driver, uaudio, 1, 1, 1);?

It doesn't hurt, but we can get rid of it indeed.

christos updated this revision to Diff 132573.Jan 10 2024, 10:36 PM

s/uaudio/snd_uaudio/. Depends on D43396.

This revision now requires review to proceed.Jan 10 2024, 10:36 PM
Harbormaster completed remote builds in B55359: Diff 132573.Jan 10 2024, 10:36 PM
christos added a parent revision: D43396: snd_uaudio: prefix module declaration with "snd_".Jan 10 2024, 10:37 PM
imp accepted this revision.Jan 11 2024, 9:18 PM

It's a little odd that we load all these for this driver. It seems a bit backwards...

However, making sure the list is complete and we can defer dealing with that issue for now.

This revision is now accepted and ready to land.Jan 11 2024, 9:18 PM
Closed by commit rG3a79c3ac8aa3: sound: add missing modules to snd_driver (authored by christos). · Explain WhyJan 16 2024, 4:50 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG3a79c3ac8aa3: sound: add missing modules to snd_driver.
emaste added a comment.Jan 16 2024, 5:37 PM
In D43394#989279, @emaste wrote:

Hrm, with the uaudio driver being loaded by USB on demand I suspect we don't want the MODULE_DEPEND(snd_driver, uaudio, 1, 1, 1);?

I don't think this was addressed

christos added a comment.Jan 16 2024, 5:39 PM
In D43394#990908, @emaste wrote:
In D43394#989279, @emaste wrote:

Hrm, with the uaudio driver being loaded by USB on demand I suspect we don't want the MODULE_DEPEND(snd_driver, uaudio, 1, 1, 1);?

I don't think this was addressed

We technically don't need it, but I kept it here for completeness.

emaste added a comment.Jan 16 2024, 6:09 PM

We technically don't need it, but I kept it here for completeness.

But does this mean that snd_uaudio will get loaded as a dependency of sound.ko rather than on demand after USB plug?

christos added a commit: rGf7db1b3d7bbf: sound: add missing modules to snd_driver.Jan 30 2024, 11:09 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
3 lines

Diff 132831

View Options

sys/dev/sound/driver.c

Loading...