Page MenuHomeFreeBSD
Differential D43454

multimedia/mkvtoolnix: Subpackage'ify
Needs ReviewPublic
Actions

Authored by riggs on Jan 14 2024, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 9, 12:48 PM
Unknown Object (File)
Fri, Mar 7, 11:42 PM
Unknown Object (File)
Feb 28 2025, 4:13 PM
Unknown Object (File)
Feb 28 2025, 3:00 PM
Unknown Object (File)
Feb 27 2025, 5:35 AM
Unknown Object (File)
Feb 26 2025, 8:39 PM
Unknown Object (File)
Feb 26 2025, 7:53 AM
Unknown Object (File)
Feb 26 2025, 7:35 AM
View All 69 Files
Subscribers
eduardo
mat

Details

Reviewers
mat
Group Reviewers
portmgr

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

riggs requested review of this revision.Jan 14 2024, 6:58 PM
riggs created this revision.
riggs added a reviewer: portmgr.
mat added a subscriber: mat.Jan 14 2024, 8:53 PM

This looks ok to me, but with the missing context, it's a bit hard to see if it could be made even better.

riggs updated this revision to Diff 132765.Jan 14 2024, 9:20 PM
riggs updated this revision to Diff 132815.Jan 16 2024, 8:39 AM
mat added a comment.Jan 16 2024, 8:44 AM

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

eduardo added a subscriber: eduardo.Jan 18 2024, 11:47 PM
riggs updated this revision to Diff 133118.Jan 21 2024, 5:54 PM
In D43454#990804, @mat wrote:

One enhancements you could add is enable MANTRANS by default and put those files in a mantrans subpackage.

Added a proposal for this.

mat requested changes to this revision.Jan 21 2024, 6:39 PM

The guimantrans seems to be a bit overboard, just put all the translated man pages into mantrans.

This revision now requires changes to proceed.Jan 21 2024, 6:39 PM
riggs updated this revision to Diff 133478.Jan 29 2024, 7:34 AM

Dropped the mantrans subpackages, include translations in main and the gui subpackage.

Revision Contents
Changeset List

PathSize
multimedia/
mkvtoolnix/
32 lines
126 lines

Diff 132765

View Options

multimedia/mkvtoolnix/Makefile

Show All 23 Lines
.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL .\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS .\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.Dd August 15, 2016 .Dd June 5, 2024
fuzUnsubmitted
Not Done
Inline Actions

Should be adjust to today on commit.

fuz: Should be adjust to today on commit.
.Dt MEMCMP 3 .Dt MEMCMP 3
.Os .Os
.Sh NAME .Sh NAME
.Nm memcmp .Nm memcmp
.Nd compare byte string .Nd compare byte string
fuzUnsubmitted
Not Done
Inline Actions
.Nm memcmp
- .Nd compare byte string
+ .Nd compare byte object
.Sh LIBRARY
fuz:
.Sh LIBRARY .Sh LIBRARY
.Lb libc .Lb libc
.Sh SYNOPSIS .Sh SYNOPSIS
.In string.h .In string.h
.Ft int .Ft int
.Fn memcmp "const void *b1" "const void *b2" "size_t len" .Fn memcmp "const void *b1" "const void *b2" "size_t len"
.Sh DESCRIPTION .Sh DESCRIPTION
The The
.Fn memcmp .Fn memcmp
function function
compares byte string compares byte objdect
andrewUnsubmitted
Done
Inline Actions
function
- compares byte objdect
+ compares byte object
.Fa b1
andrew:
.Fa b1 .Fa b1
against byte string against byte object
.Fa b2 . .Fa b2 .
Both strings are assumed to be Both objects are assumed to be
.Fa len .Fa len
bytes long. bytes long.
.Sh RETURN VALUES .Sh RETURN VALUES
The The
.Fn memcmp .Fn memcmp
function function returns zero if the two objects are identical.
returns zero if the two strings are identical, Zero-length objects are considered identical.
otherwise returns the difference between the first two differing bytes The
(treated as .Fn memcmp
.Vt "unsigned char" function returns a negative value if the first differing byte has a lower
values, so that value in
.Sq Li \e200 .Fa b1
is greater than and a positive value if the first differing byte has a higher value in
.Sq Li \&\e0 , .Fa b1 .
emasteAuthorUnsubmitted
Done
Inline Actions
.Fn memcmp
- function returns if the two objects are identical.
+ function returns zero if the two objects are identical.
Zero-length objects are considered identical.
emaste:
fuzUnsubmitted
Not Done
Inline Actions
.Fn memcmp
function returns a negative value if the first differing byte has a lower
value in
.Fa b1
+ than in
+ .Fa b2
and a positive value if the first differing byte has a higher value in
- .Fa b1 .
+ .Fa b1
+ than in
+ .Fa b2 .
.Sh SEE ALSO
fuz:
for example).
Zero-length strings are always identical.
.Sh SEE ALSO .Sh SEE ALSO
.Xr bcmp 3 , .Xr bcmp 3 ,
.Xr strcasecmp 3 , .Xr strcasecmp 3 ,
.Xr strcmp 3 , .Xr strcmp 3 ,
.Xr strcoll 3 , .Xr strcoll 3 ,
.Xr strxfrm 3 , .Xr strxfrm 3 ,
.Xr timingsafe_memcmp 3 , .Xr timingsafe_memcmp 3 ,
.Xr wmemcmp 3 .Xr wmemcmp 3
.Sh STANDARDS .Sh STANDARDS
The The
.Fn memcmp .Fn memcmp
function function
conforms to conforms to
.St -isoC . .St -isoC .
View Options

multimedia/mkvtoolnix/pkg-plist

Show All 23 Lines
.\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL .\" FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
.\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS .\" DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
.\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) .\" OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
.\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT .\" HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
.\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY .\" LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
.\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF .\" OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
.\" SUCH DAMAGE. .\" SUCH DAMAGE.
.\" .\"
.Dd August 15, 2016 .Dd June 5, 2024
fuzUnsubmitted
Not Done
Inline Actions

Should be adjust to today on commit.

fuz: Should be adjust to today on commit.
.Dt MEMCMP 3 .Dt MEMCMP 3
.Os .Os
.Sh NAME .Sh NAME
.Nm memcmp .Nm memcmp
.Nd compare byte string .Nd compare byte string
fuzUnsubmitted
Not Done
Inline Actions
.Nm memcmp
- .Nd compare byte string
+ .Nd compare byte object
.Sh LIBRARY
fuz:
.Sh LIBRARY .Sh LIBRARY
.Lb libc .Lb libc
.Sh SYNOPSIS .Sh SYNOPSIS
.In string.h .In string.h
.Ft int .Ft int
.Fn memcmp "const void *b1" "const void *b2" "size_t len" .Fn memcmp "const void *b1" "const void *b2" "size_t len"
.Sh DESCRIPTION .Sh DESCRIPTION
The The
.Fn memcmp .Fn memcmp
function function
compares byte string compares byte objdect
andrewUnsubmitted
Done
Inline Actions
function
- compares byte objdect
+ compares byte object
.Fa b1
andrew:
.Fa b1 .Fa b1
against byte string against byte object
.Fa b2 . .Fa b2 .
Both strings are assumed to be Both objects are assumed to be
.Fa len .Fa len
bytes long. bytes long.
.Sh RETURN VALUES .Sh RETURN VALUES
The The
.Fn memcmp .Fn memcmp
function function returns zero if the two objects are identical.
returns zero if the two strings are identical, Zero-length objects are considered identical.
otherwise returns the difference between the first two differing bytes The
(treated as .Fn memcmp
.Vt "unsigned char" function returns a negative value if the first differing byte has a lower
values, so that value in
.Sq Li \e200 .Fa b1
is greater than and a positive value if the first differing byte has a higher value in
.Sq Li \&\e0 , .Fa b1 .
emasteAuthorUnsubmitted
Done
Inline Actions
.Fn memcmp
- function returns if the two objects are identical.
+ function returns zero if the two objects are identical.
Zero-length objects are considered identical.
emaste:
fuzUnsubmitted
Not Done
Inline Actions
.Fn memcmp
function returns a negative value if the first differing byte has a lower
value in
.Fa b1
+ than in
+ .Fa b2
and a positive value if the first differing byte has a higher value in
- .Fa b1 .
+ .Fa b1
+ than in
+ .Fa b2 .
.Sh SEE ALSO
fuz:
for example).
Zero-length strings are always identical.
.Sh SEE ALSO .Sh SEE ALSO
.Xr bcmp 3 , .Xr bcmp 3 ,
.Xr strcasecmp 3 , .Xr strcasecmp 3 ,
.Xr strcmp 3 , .Xr strcmp 3 ,
.Xr strcoll 3 , .Xr strcoll 3 ,
.Xr strxfrm 3 , .Xr strxfrm 3 ,
.Xr timingsafe_memcmp 3 , .Xr timingsafe_memcmp 3 ,
.Xr wmemcmp 3 .Xr wmemcmp 3
.Sh STANDARDS .Sh STANDARDS
The The
.Fn memcmp .Fn memcmp
function function
conforms to conforms to
.St -isoC . .St -isoC .