powerpc psim: Use bus_generic_rman_*
ClosedPublic
Actions

Authored by jhb on Jan 12 2024, 10:32 PM.

Details

Reviewers

imp
grehan
jhibbits

Commits

rGd7c16b333455: powerpc psim: Use bus_generic_rman_*

Summary

Split out bits of iobus_activate/deactive_resource to implement iobus_map/unmap_resource.

Use bus_generic_rman_* methods in several bus methods to handle memory and I/O port resources.

Add an implementation of bus_adjust_resource.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 55407
Build 52296: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 12 2024, 10:32 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptJan 12 2024, 10:32 PM

jhb requested review of this revision.Jan 12 2024, 10:32 PM

Harbormaster completed remote builds in B55407: Diff 132712.Jan 12 2024, 10:32 PM

jhb added a parent revision: D43432: powerpc ps3bus: Use bus_generic_rman_*.Jan 12 2024, 10:32 PM

jhb added a child revision: D43434: powerpc mpc85xx: Use bus_generic_rman_*.

jhb added reviewers: grehan, jhibbits.Jan 12 2024, 10:38 PM

Does psim even still work?

This revision is now accepted and ready to land.Jan 19 2024, 2:53 AM

In D43433#991937, @jhibbits wrote:

Does psim even still work?

Let me give it a try. Seems to still be maintained in upstream gdb.

I with there was a 'no objection' button here.
But I think between the helper and the small code reorg this is what we want.
I'm not completely sure, and the lack of testability makes me uneasy.
But I think they are OK enough for me to tick the 'yes' button failing to find any reason to say no.

Closed by commit rGd7c16b333455: powerpc psim: Use bus_generic_rman_* (authored by jhb). · Explain WhyJan 23 2024, 5:46 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGd7c16b333455: powerpc psim: Use bus_generic_rman_*.