Page MenuHomeFreeBSD
Differential D43278

acl_equiv_mode_np: zero mode on just inited ACL
ClosedPublic
Actions

Authored by brooks on Jan 2 2024, 10:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 4, 1:01 AM
Unknown Object (File)
Sun, Sep 20, 10:32 PM
Unknown Object (File)
Sat, Sep 12, 4:12 AM
Unknown Object (File)
Wed, Sep 9, 9:51 PM
Unknown Object (File)
Wed, Sep 9, 12:56 PM
Unknown Object (File)
Wed, Sep 9, 3:06 AM
Unknown Object (File)
Tue, Sep 8, 5:49 PM
Unknown Object (File)
Tue, Sep 8, 2:51 PM
View All Files
Subscribers
imp

Details

Reviewers
arrowd
markj
kevans
Commits
rG85c9d36497fc: acl_equiv_mode_np: zero mode on just inited ACL
Summary

You can't return 0 and not write the mode if mode_p is non-NULL. That
violates the API contract and in common usage leaves stack trash in
*mode_p.

The acl_equiv_mode_test test passed by accident.

Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 55202
Build 52091: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 2 2024, 10:04 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 2 2024, 10:04 PM
brooks requested review of this revision.Jan 2 2024, 10:04 PM
Harbormaster completed remote builds in B55202: Diff 132155.Jan 2 2024, 10:04 PM
brooks added a comment.EditedJan 2 2024, 11:39 PM

I bumped into this on CheriBSD were different stack layout made mode non-zero in the caller.

kevans accepted this revision.Jan 3 2024, 12:21 AM
This revision is now accepted and ready to land.Jan 3 2024, 12:21 AM
markj accepted this revision.Jan 3 2024, 2:37 PM
Closed by commit rG85c9d36497fc: acl_equiv_mode_np: zero mode on just inited ACL (authored by brooks). · Explain WhyJan 3 2024, 4:51 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG85c9d36497fc: acl_equiv_mode_np: zero mode on just inited ACL.

Revision Contents
Changeset List

PathSize
lib/
libc/
posix1e/
3 lines

Diff 132155

View Options

lib/libc/posix1e/acl_equiv_mode_np.c

Loading...