acl_equiv_mode_np: zero mode on just inited ACL
ClosedPublic
Actions

Authored by brooks on Jan 2 2024, 10:04 PM.

Details

Reviewers

arrowd
markj
kevans

Commits

rG85c9d36497fc: acl_equiv_mode_np: zero mode on just inited ACL

Summary

You can't return 0 and not write the mode if mode_p is non-NULL. That
violates the API contract and in common usage leaves stack trash in
*mode_p.

The acl_equiv_mode_test test passed by accident.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 55202
Build 52091: arc lint + arc unit

Event Timeline

brooks created this revision.Jan 2 2024, 10:04 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 2 2024, 10:04 PM

brooks requested review of this revision.Jan 2 2024, 10:04 PM

Harbormaster completed remote builds in B55202: Diff 132155.Jan 2 2024, 10:04 PM

I bumped into this on CheriBSD were different stack layout made mode non-zero in the caller.

kevans accepted this revision.Jan 3 2024, 12:21 AM

This revision is now accepted and ready to land.Jan 3 2024, 12:21 AM

markj accepted this revision.Jan 3 2024, 2:37 PM

Closed by commit rG85c9d36497fc: acl_equiv_mode_np: zero mode on just inited ACL (authored by brooks). · Explain WhyJan 3 2024, 4:51 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG85c9d36497fc: acl_equiv_mode_np: zero mode on just inited ACL.

Revision Contents
Changeset List

Path

Size

lib/

libc/

posix1e/

acl_equiv_mode_np.c

3 lines

Diff 132155

View Options

lib/libc/posix1e/acl_equiv_mode_np.c

acl_equiv_mode_np: zero mode on just inited ACLClosedPublicActions