Support interrupts binding in GICv3 and ITS
ClosedPublic
Actions

Authored by zbb on Feb 8 2016, 1:46 PM.

Details

Reviewers

wma
andrew

Commits

rS295519: Support interrupts binding in GICv3 and ITS

Summary

Add MOVI command and routine for the LPI migration
Allow to search for the ITS device descriptor using not only devID but also LPI number.
Bind SPIs in the Distributor
Don't bind its_dev to collection. Keep track of the collection IDs for each LPI.

Reviewed by:
Obtained from: Semihalf
Sponsored by: Cavium
Differential Revision:

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

zbb retitled this revision from to Support interrupts binding in GICv3 and ITS.

zbb updated this object.

zbb edited the test plan for this revision. (Show Details)

zbb added reviewers: andrew, wma.

zbb set the repository for this revision to rS FreeBSD src repository - subversion.

zbb added a subscriber: arm64.

sys/arm64/arm64/gic_v3_its.c
992–994	how is the its_dev protected outside of this region?
sys/arm64/arm64/gic_v3_var.h
135	Out of curiosity, what are the command #s based on?

sys/arm64/arm64/gic_v3_its.c
992–994	We lock the `its_device_find_locked()` to avoid mismatch in general itd_device list. I assume that the interrupt resources that are managed through `its_dev` here are allocated and protected by the resource manager. So there should be no another driver thread that is going to work on that `its_dev`. However, after rethinking, I can see no point of having `its_dev->col->col_id`. I would probably change that in the next iteration.
sys/arm64/arm64/gic_v3_var.h
135	The numbers are defined by the ITS architecture. This is described in the `GIC Architecture Specification PRD03-GENC-010745 24.0`

Don't bind its_dev to collection. Keep track of the collection IDs for each LPI.

wma accepted this revision.Feb 11 2016, 6:23 AM

wma edited edge metadata.

wma added inline comments.

sys/arm64/arm64/gic_v3_its.c
921	Now, the execution of lpi_free_chunk is no longer guarded by the lock. I might not see all dependencies here, but please check before commiting if there is a possibility of use-after-free of lpi_col_ids if this function is reentered by mmultiple threads. If so, it might be fixed as following: tmp = lpic->lpi_col_ids; lpic->lpi_col_ids = NULL; dmb(); free(tmp);