libc: simplify MDASM/NOASM checks
ClosedPublic
Actions

Authored by brooks on Dec 5 2023, 7:09 PM.

Tags

None

Referenced Files

	F163287944: D42915.id131080.diff
	Tue, Jul 21, 6:28 PM

	Unknown Object (File)
	Fri, Jul 10, 7:22 PM

	Unknown Object (File)
	Fri, Jul 10, 6:01 AM

	Unknown Object (File)
	Wed, Jul 8, 7:59 PM

	Unknown Object (File)
	Wed, Jul 8, 12:16 AM

	Unknown Object (File)
	Tue, Jul 7, 6:52 PM

	Unknown Object (File)
	Tue, Jul 7, 9:18 AM

	Unknown Object (File)
	Tue, Jun 30, 11:09 PM

View All Files

Subscribers

imp

Details

Reviewers

kib
imp

Commits

rG1b0471936f7e: libc: simplify MDASM/NOASM checks
rGfc0288993cda: libc: simplify MDASM/NOASM checks

Summary

Use boolean evaluation of :M matches and a single if statement.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 54802
Build 51691: arc lint + arc unit

Event Timeline

brooks created this revision.Dec 5 2023, 7:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2023, 7:09 PM

brooks requested review of this revision.Dec 5 2023, 7:09 PM

Harbormaster completed remote builds in B54802: Diff 131045.Dec 5 2023, 7:09 PM

brooks added a parent revision: D42914: libc: don't needlessly add vfork.o to NOASM.Dec 5 2023, 7:09 PM

kib accepted this revision.Dec 6 2023, 12:11 AM

This revision is now accepted and ready to land.Dec 6 2023, 12:11 AM

imp accepted this revision.Dec 6 2023, 2:03 AM

Closed by commit rGfc0288993cda: libc: simplify MDASM/NOASM checks (authored by brooks). · Explain WhyDec 6 2023, 8:49 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGfc0288993cda: libc: simplify MDASM/NOASM checks.

brooks added a commit: rG1b0471936f7e: libc: simplify MDASM/NOASM checks.Jan 2 2024, 5:01 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

Makefile.inc

4 lines

Diff 131045

View Options

libc: simplify MDASM/NOASM checksClosedPublicActions