libc: simplify MDASM/NOASM checks
ClosedPublic
Actions

Authored by brooks on Dec 5 2023, 7:09 PM.

Tags

None

Referenced Files

	F170629941: D42915.id.diff
	Sat, Sep 5, 5:33 PM

	Unknown Object (File)
	Fri, Sep 4, 4:31 AM

	Unknown Object (File)
	Fri, Sep 4, 12:56 AM

	Unknown Object (File)
	Thu, Sep 3, 2:06 AM

	Unknown Object (File)
	Wed, Sep 2, 8:18 PM

	Unknown Object (File)
	Wed, Sep 2, 5:09 PM

	Unknown Object (File)
	Wed, Sep 2, 9:02 AM

	Unknown Object (File)
	Wed, Sep 2, 12:29 AM

View All Files

Subscribers

imp

Details

Reviewers

kib
imp

Commits

rG1b0471936f7e: libc: simplify MDASM/NOASM checks
rGfc0288993cda: libc: simplify MDASM/NOASM checks

Summary

Use boolean evaluation of :M matches and a single if statement.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Dec 5 2023, 7:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 5 2023, 7:09 PM

brooks requested review of this revision.Dec 5 2023, 7:09 PM

Harbormaster completed remote builds in B54802: Diff 131045.Dec 5 2023, 7:09 PM

brooks added a parent revision: D42914: libc: don't needlessly add vfork.o to NOASM.Dec 5 2023, 7:09 PM

kib accepted this revision.Dec 6 2023, 12:11 AM

This revision is now accepted and ready to land.Dec 6 2023, 12:11 AM

imp accepted this revision.Dec 6 2023, 2:03 AM

Closed by commit rGfc0288993cda: libc: simplify MDASM/NOASM checks (authored by brooks). · Explain WhyDec 6 2023, 8:49 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGfc0288993cda: libc: simplify MDASM/NOASM checks.

brooks added a commit: rG1b0471936f7e: libc: simplify MDASM/NOASM checks.Jan 2 2024, 5:01 PM

Revision Contents
Changeset List

Path

Size

lib/

libc/

sys/

Makefile.inc

4 lines

Diff 131080

View Options

libc: simplify MDASM/NOASM checksClosedPublicActions