lockf: hide unavailable error with -n -s
ClosedPublic
Actions

Authored by kevans on Nov 22 2023, 5:11 AM.

Details

Reviewers

0mp
allanjude

Group Reviewers

Klara

Commits

rG3041e6950d07: lockf: hide unavailable error with -n -s

Summary

The error message is expected, allow -s to suppress just that one since
it would loosely fall under the definition of "failure to acquire the
lock" described in the manpage for the -s option.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54559
Build 51448: arc lint + arc unit

Event Timeline

kevans created this revision.Nov 22 2023, 5:11 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 22 2023, 5:11 AM

kevans requested review of this revision.Nov 22 2023, 5:11 AM

Harbormaster completed remote builds in B54559: Diff 130415.Nov 22 2023, 5:11 AM

kevans added a child revision: D42712: lockf: correct omission in the usage statement.Nov 22 2023, 5:12 AM

LGTM.

This revision is now accepted and ready to land.Nov 22 2023, 9:23 AM

reviewed-by: allanjude

des added a subscriber: des.Nov 22 2023, 2:34 PM

des added inline comments.

usr.bin/lockf/lockf.c
182	This is a bit repetitive, I would prefer `if (!silent) warn(); exit();`.

kevans marked an inline comment as done.Nov 22 2023, 4:35 PM

kevans added inline comments.

usr.bin/lockf/lockf.c
182	Ah, yeah, I like that more. Fixed locally, thanks.

Closed by commit rG3041e6950d07: lockf: hide unavailable error with -n -s (authored by kevans). · Explain WhyNov 26 2023, 4:11 AM

This revision was automatically updated to reflect the committed changes.

kevans marked an inline comment as done.

kevans added a commit: rG3041e6950d07: lockf: hide unavailable error with -n -s.

Revision Contents
Changeset List

Path

Size

usr.bin/

lockf/

lockf.c

16 lines

Diff 130415

View Options

lockf: hide unavailable error with -n -sClosedPublicActions