Page MenuHomeFreeBSD
Differential D5192

82598 doesn't support SCTP checksum offloading
ClosedPublic
Actions

Authored by tuexen on Feb 4 2016, 5:12 PM.
Tags
None
Referenced Files
F105784791: D5192.id13012.diff
Fri, Dec 20, 4:07 PM
F105769626: D5192.diff
Fri, Dec 20, 10:56 AM
Unknown Object (File)
Sep 22 2024, 3:23 AM
Unknown Object (File)
Sep 21 2024, 4:35 AM
Unknown Object (File)
Sep 15 2024, 11:04 PM
Unknown Object (File)
Sep 10 2024, 11:17 AM
Unknown Object (File)
Sep 8 2024, 8:14 AM
Unknown Object (File)
Sep 8 2024, 7:48 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
erj
sbruno
Group Reviewers
Intel Networking
Commits
rS296056: MFC r295273:
rS295273: In FreeBSD 10 and higher the driver announces SCTP checksum offloading support
Summary

In FreeBSD 10 and higher the driver announces SCTP checksum offloading support even for 82598, which doesn't support it. The legacy code has a check for it, which was missed when the code for dealing with CSUM_IP6_* was added.

Test Plan

Just code review, since I don't have a card with a 82598 chip.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tuexen updated this revision to Diff 13012.Feb 4 2016, 5:12 PM
tuexen retitled this revision from to 82598 doesn't support SCTP checksum offloading.
tuexen updated this object.
tuexen edited the test plan for this revision. (Show Details)
tuexen added a reviewer: Intel Networking.
tuexen set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a reviewer: sbruno. · View Herald TranscriptFeb 4 2016, 5:12 PM
Herald added a subscriber: imp. · View Herald Transcript
tuexen added a reviewer: erj.Feb 4 2016, 5:15 PM
erj accepted this revision.Feb 4 2016, 5:23 PM
erj edited edge metadata.

It looks good.

This revision is now accepted and ready to land.Feb 4 2016, 5:23 PM
tuexen added a comment.Feb 4 2016, 5:31 PM

Hi Eric,

should I wait for a review from sbruno@ or go ahead and commit it?

Best regards
Michael

erj added a comment.Feb 4 2016, 5:34 PM

You can go ahead and commit this one.

sbruno accepted this revision.Feb 4 2016, 5:50 PM
sbruno edited edge metadata.
Closed by commit rS295273: In FreeBSD 10 and higher the driver announces SCTP checksum offloading support (authored by tuexen). · Explain WhyFeb 4 2016, 6:09 PM
This revision was automatically updated to reflect the committed changes.
tuexen mentioned this in rS296056: MFC r295273:.Feb 26 2016, 11:07 AM

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
ixgbe/
18 lines

Diff 13017

View Options

head/sys/dev/ixgbe/if_ix.c

Loading...