Differential D42490

certctl: Convert line endings before inspecting files.
ClosedPublic
Actions

Authored by des on Nov 7 2023, 1:14 PM.

Details

Reviewers

allanjude

Group Reviewers

security

Commits

rGf7d16a627efa: certctl: Convert line endings before inspecting files.

Summary

This ensures that certificate files or bundles with DOS or Mac line
endings are recognized as such and handled identically to those with
Unix line endings.

PR: 274952

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 54312
Build 51202: arc lint + arc unit

Event Timeline

des created this revision.Nov 7 2023, 1:14 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 7 2023, 1:14 PM

des requested review of this revision.Nov 7 2023, 1:14 PM

Harbormaster completed remote builds in B54312: Diff 129811.Nov 7 2023, 1:14 PM

reviewed-by: allanjude

This revision is now accepted and ready to land.Nov 7 2023, 7:28 PM

Closed by commit rGf7d16a627efa: certctl: Convert line endings before inspecting files. (authored by des). · Explain WhyNov 7 2023, 7:54 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGf7d16a627efa: certctl: Convert line endings before inspecting files..

While technically I have no objection, I still consider that the split approach is wrong as layed out in the PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274952

des mentioned this in rG9c34a6876a60: certctl: Split certificate bundles before processing..May 30 2025, 12:42 PM

des mentioned this in rGfb33dd91ae8a: certctl: Split certificate bundles before processing..May 30 2025, 4:00 PM