Page MenuHomeFreeBSD
Differential D42490

certctl: Convert line endings before inspecting files.
ClosedPublic
Actions

Authored by des on Nov 7 2023, 1:14 PM.
Tags
None
Referenced Files
F108519606: D42490.diff
Sat, Jan 25, 8:28 PM
Unknown Object (File)
Fri, Jan 17, 1:25 PM
Unknown Object (File)
Wed, Jan 15, 1:52 PM
Unknown Object (File)
Sat, Jan 11, 9:51 AM
Unknown Object (File)
Sat, Jan 11, 6:22 AM
Unknown Object (File)
Sun, Jan 5, 10:13 AM
Unknown Object (File)
Dec 7 2024, 12:38 PM
Unknown Object (File)
Oct 24 2024, 8:38 AM
View All 52 Files
Subscribers
imp
michaelo

Details

Reviewers
allanjude
Group Reviewers
security
Commits
rGf7d16a627efa: certctl: Convert line endings before inspecting files.
Summary

This ensures that certificate files or bundles with DOS or Mac line
endings are recognized as such and handled identically to those with
Unix line endings.

PR: 274952

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54312
Build 51202: arc lint + arc unit

Event Timeline

des created this revision.Nov 7 2023, 1:14 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 7 2023, 1:14 PM
des requested review of this revision.Nov 7 2023, 1:14 PM
Harbormaster completed remote builds in B54312: Diff 129811.Nov 7 2023, 1:14 PM
allanjude accepted this revision.Nov 7 2023, 7:28 PM

reviewed-by: allanjude

This revision is now accepted and ready to land.Nov 7 2023, 7:28 PM
Closed by commit rGf7d16a627efa: certctl: Convert line endings before inspecting files. (authored by des). · Explain WhyNov 7 2023, 7:54 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGf7d16a627efa: certctl: Convert line endings before inspecting files..
michaelo added a comment.Nov 7 2023, 10:07 PM

While technically I have no objection, I still consider that the split approach is wrong as layed out in the PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274952

Revision Contents
Changeset List

PathSize
usr.sbin/
certctl/
9 lines

Diff 129811

View Options

usr.sbin/certctl/certctl.sh

Loading...