Differential D42362

pf tests: ensure that we generate all permutations for SCTP multihome
ClosedPublic
Actions

Authored by kp on Oct 25 2023, 2:23 PM.

Tags

None

Referenced Files

	F152891554: D42362.id.diff
	Fri, Apr 17, 8:04 PM

	Unknown Object (File)
	Wed, Apr 15, 11:27 PM

	Unknown Object (File)
	Mon, Apr 13, 9:23 PM

	Unknown Object (File)
	Sun, Apr 12, 7:05 PM

	Unknown Object (File)
	Sat, Apr 11, 3:08 PM

	Unknown Object (File)
	Mar 17 2026, 7:02 AM

	Unknown Object (File)
	Mar 17 2026, 12:48 AM

	Unknown Object (File)
	Mar 16 2026, 12:32 PM

View All 85 Files

Subscribers

Details

Reviewers

None

Group Reviewers

Commits

rGdee71d8e6eab: pf tests: ensure that we generate all permutations for SCTP multihome
rGd322e5d76aa3: pf tests: ensure that we generate all permutations for SCTP multihome
rG483d5c4075e0: pf tests: ensure that we generate all permutations for SCTP multihome

Summary

The initial multihome implementation was a little simplistic, and failed
to create all of the required states. Given a client with IP 1 and 2 and
a server with IP 3 and 4 we end up creating states for 1 - 3 and 2 - 3,
as well as 3 - 1 and 4 - 1, but not for 2 - 4.

Check for this.

MFC after: 1 week
Sponsored by: Orange Business Services

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Oct 25 2023, 2:23 PM

Herald added subscribers: glebius, melifaro, farrokhi, imp. · View Herald TranscriptOct 25 2023, 2:23 PM

kp requested review of this revision.Oct 25 2023, 2:23 PM

Harbormaster completed remote builds in B54167: Diff 129381.Oct 25 2023, 2:23 PM

kp added a parent revision: D42361: pf: fix missing SCTP multihomed states.Oct 25 2023, 2:23 PM

This revision was not accepted when it landed; it landed in state Needs Review.Oct 31 2023, 3:04 PM

This revision was landed with ongoing or failed builds.

Closed by commit rG483d5c4075e0: pf tests: ensure that we generate all permutations for SCTP multihome (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG483d5c4075e0: pf tests: ensure that we generate all permutations for SCTP multihome.

kp added a commit: rGd322e5d76aa3: pf tests: ensure that we generate all permutations for SCTP multihome.Nov 7 2023, 3:47 PM

kp added a commit: rGdee71d8e6eab: pf tests: ensure that we generate all permutations for SCTP multihome.

Revision Contents
Changeset List

Path

Size

tests/

sys/

netpfil/

pf/

61 lines

Diff 129552

tests/sys/netpfil/pf/sctp.py

Loading...