Page MenuHomeFreeBSD
Differential D42349

cleanup: set generic version for devel/subversion
ClosedPublic
Actions

Authored by michaelo on Oct 24 2023, 11:54 AM.
Tags
None
Referenced Files
F157126270: D42349.id129452.diff
Mon, May 18, 3:17 PM
F157112312: D42349.id129289.diff
Mon, May 18, 1:07 PM
F157087496: D42349.id129294.diff
Mon, May 18, 9:07 AM
F157037225: D42349.id.diff
Mon, May 18, 1:58 AM
F157026916: D42349.id129452.diff
Mon, May 18, 12:45 AM
Unknown Object (File)
Sun, May 17, 9:17 PM
Unknown Object (File)
Sun, May 17, 1:55 PM
Unknown Object (File)
Mon, Apr 27, 9:54 PM
View All Files
Subscribers
None

Details

Reviewers
jrm
otis
lev
Commits
R11:528f7fc28f25: cleanup: set generic version for devel/subversion
Summary

PR: 253566
Approved by: jrm (mentor), otis (mentor), maintainer timeout

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54149
Build 51039: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Oct 24 2023, 11:54 AM
michaelo created this revision.
Harbormaster completed remote builds in B54149: Diff 129287.Oct 24 2023, 11:54 AM
michaelo added a parent revision: D42348: devel/subversion-lts: update port to next LTS version: 1.14.2.Oct 24 2023, 11:54 AM
michaelo updated this revision to Diff 129289.Oct 24 2023, 12:02 PM

Add review URL

Harbormaster completed remote builds in B54151: Diff 129289.Oct 24 2023, 12:02 PM
michaelo added a comment.Oct 24 2023, 12:02 PM

This is a followup to https://reviews.freebsd.org/D42348.

otis added inline comments.Oct 24 2023, 12:35 PM
devel/p5-SVN-Hooks/Makefile
20

I wonder why are > and >= intermixed here.

michaelo added inline comments.Oct 24 2023, 12:38 PM
devel/p5-SVN-Hooks/Makefile
20

Looking at the Porter's Handbook it should be >0. I will fix for hunks I have changed. Good catch.

michaelo updated this revision to Diff 129294.Oct 24 2023, 12:40 PM

Address comments from otis

Harbormaster completed remote builds in B54152: Diff 129294.Oct 24 2023, 12:40 PM
michaelo marked an inline comment as done.Oct 24 2023, 12:40 PM

Issue addressed.

michaelo added a comment.Oct 27 2023, 8:55 AM

Guys, please have a look at this again. It is straight forward.

jrm added inline comments.Oct 27 2023, 1:25 PM
devel/p5-SVN-Hooks/Makefile
20

If no particular version is required, just omit the version range specifier. That is, just use svn:devel/subversion as you did below for portshaker.

devel/p5-SVN-Look/Makefile
18

Same comment as above.

devel/statsvn/Makefile
14

Same comment as above.

michaelo updated this revision to Diff 129452.Oct 27 2023, 1:34 PM

Drop portshaker because it is an invalid change.

Harbormaster completed remote builds in B54185: Diff 129452.Oct 27 2023, 1:34 PM
michaelo added a comment.Oct 27 2023, 1:34 PM

While you are right, there is a difference. Portshaker depends on the executable svn, but the other ports depend on the package. I don't know whether they do use the executable or not. Having said that, I think this is still correct. The Portshaker hunk is wrong, antoine@ pointed me to this.

jrm accepted this revision.Oct 27 2023, 1:37 PM
This revision is now accepted and ready to land.Oct 27 2023, 1:37 PM
Closed by commit R11:528f7fc28f25: cleanup: set generic version for devel/subversion (authored by michaelo). · Explain WhyOct 27 2023, 1:46 PM
This revision was automatically updated to reflect the committed changes.
michaelo added a commit: R11:528f7fc28f25: cleanup: set generic version for devel/subversion.

Revision Contents
Changeset List

PathSize
devel/
p5-SVN-Hooks/
2 lines
p5-SVN-Look/
2 lines
statsvn/
2 lines
ports-mgmt/
portshaker/
7 lines

Diff 129287

View Options

devel/p5-SVN-Hooks/Makefile

Loading...
View Options

devel/p5-SVN-Look/Makefile

Loading...
View Options

devel/statsvn/Makefile

Loading...
View Options

ports-mgmt/portshaker/Makefile

Loading...