Page MenuHomeFreeBSD
Differential D42236

bsdinstall partedit: Apply changes from scripted installs
ClosedPublic
Actions

Authored by jhb on Oct 16 2023, 9:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 1, 9:12 PM
Unknown Object (File)
Sun, Mar 1, 9:32 AM
Unknown Object (File)
Sun, Mar 1, 12:46 AM
Unknown Object (File)
Sat, Feb 28, 7:38 PM
Unknown Object (File)
Sat, Feb 28, 6:25 PM
Unknown Object (File)
Wed, Feb 25, 10:25 PM
Unknown Object (File)
Sat, Feb 21, 10:59 PM
Unknown Object (File)
Wed, Feb 18, 10:07 AM
View All 96 Files
Subscribers
imp
jrtc27

Details

Reviewers
emaste
brooks
cognet
Commits
rGc81bdb499868: bsdinstall partedit: Apply changes from scripted installs
rG929e4723c3f5: bsdinstall partedit: Apply changes from scripted installs
rGbfbb28f3b1b6: bsdinstall partedit: Apply changes from scripted installs
rG5307bbcc038f: bsdinstall partedit: Apply changes from scripted installs
Summary

I got a check inverted in a previous cleanup commit and as a result
partedit was only applying GEOM changes (and generating an /etc/fstab)
if it got an error reading the current GEOM mesh. Instead, it needed
to do those actions if it succeeded in reading the mesh.

The lack of /etc/fstab meant that bsdinstall mount didn't mount
anything in a scripted install.

PR: 273723
Reported by: Andrey Fesenko <andrey@bsdnir.info>
Reported by: Michal Nowak <mnowak@startmail.com>
Fixes: 230990991965 bsdinstall: Handle errors from geom_gettree.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54013
Build 50903: arc lint + arc unit

Revision Contents
Changeset List

PathSize
usr.sbin/
bsdinstall/
partedit/
2 lines

Diff 128855

View Options

usr.sbin/bsdinstall/partedit/partedit.c

Loading...