Page MenuHomeFreeBSD
Differential D42186

pci: Set the domain in the pci_generic driver
ClosedPublic
Actions

Authored by andrew on Oct 13 2023, 10:24 AM.
Tags
None
Referenced Files
F169304090: D42186.id128740.diff
Tue, Sep 1, 4:05 AM
F169301599: D42186.id128818.diff
Tue, Sep 1, 3:59 AM
F169289294: D42186.id128725.diff
Tue, Sep 1, 3:32 AM
F169282846: D42186.diff
Tue, Sep 1, 3:17 AM
Unknown Object (File)
Sat, Aug 22, 10:51 PM
Unknown Object (File)
Thu, Aug 20, 4:38 PM
Unknown Object (File)
Tue, Aug 11, 2:20 PM
Unknown Object (File)
Tue, Aug 11, 2:20 PM
View All Files
Subscribers
markj

Details

Reviewers
jhb
imp
gallatin
markj
Commits
rG729576a3d540: pci: Set the domain in the pci_generic driver
rG7098f3c7569c: pci: Set the domain in the pci_generic driver
Summary

Tell bus_dma(9) which NUMA domain the PCI driver is closest to so it
can allocate memory from there when possible.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Oct 13 2023, 10:24 AM
andrew created this revision.
Harbormaster completed remote builds in B53957: Diff 128709.Oct 13 2023, 10:24 AM
andrew mentioned this in D42187: arm64: Teach bus_dma on arm64 about NUMA.Oct 13 2023, 3:01 PM
markj added a subscriber: markj.Oct 13 2023, 3:05 PM
markj added inline comments.
sys/dev/pci/pci_host_generic.c
108

If you're intentionally squashing errors, please add a comment and/or don't bother setting error.

andrew updated this revision to Diff 128725.Oct 13 2023, 3:19 PM

Stop setting error

Harbormaster completed remote builds in B53968: Diff 128725.Oct 13 2023, 3:19 PM
markj accepted this revision.Oct 13 2023, 3:20 PM
markj added inline comments.
sys/dev/pci/pci_host_generic.c
111
This revision is now accepted and ready to land.Oct 13 2023, 3:20 PM
andrew updated this revision to Diff 128740.Oct 13 2023, 4:24 PM

Add (void)

This revision now requires review to proceed.Oct 13 2023, 4:24 PM
Harbormaster completed remote builds in B53971: Diff 128740.Oct 13 2023, 4:24 PM
jhb accepted this revision.Oct 13 2023, 10:10 PM
jhb added inline comments.
sys/dev/pci/pci_host_generic.c
106

Nit: blank line before comment.

This revision is now accepted and ready to land.Oct 13 2023, 10:10 PM
Closed by commit rG7098f3c7569c: pci: Set the domain in the pci_generic driver (authored by andrew). · Explain WhyOct 16 2023, 10:48 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG7098f3c7569c: pci: Set the domain in the pci_generic driver.
andrew added a commit: rG729576a3d540: pci: Set the domain in the pci_generic driver.Feb 19 2024, 4:46 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
9 lines

Diff 128818

View Options

sys/dev/pci/pci_host_generic.c

Loading...