Differential D41903

ndp: cope with unresolved neighbours
ClosedPublic
Actions

Authored by kp on Sep 18 2023, 5:03 PM.

Details

Reviewers

Group Reviewers

pfsense
network

Commits

rGa9326cd7656b: ndp: cope with unresolved neighbours
rG100bed131d76: ndp: cope with unresolved neighbours
rGb57df6fbcc48: ndp: cope with unresolved neighbours

Summary

If we've not (yet) resolved a neighbour nda_lladdr will be NULL, and
NLA_DATA_LEN(neigh->nda_lladdr) will dereference a NULL pointer.

Avoid that by checking nda_lladdr first, and only dereferencing if it's
not NULL.

Test case:
ping6 -c 1 <non-existant neighbour>
ndp -a

MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Sep 18 2023, 5:03 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 18 2023, 5:03 PM

kp requested review of this revision.Sep 18 2023, 5:03 PM

Harbormaster completed remote builds in B53631: Diff 127507.Sep 18 2023, 5:04 PM

melifaro accepted this revision.Sep 18 2023, 6:09 PM

This revision is now accepted and ready to land.Sep 18 2023, 6:09 PM

Closed by commit rGb57df6fbcc48: ndp: cope with unresolved neighbours (authored by kp). · Explain WhySep 18 2023, 6:13 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGb57df6fbcc48: ndp: cope with unresolved neighbours.

kp added a commit: rG100bed131d76: ndp: cope with unresolved neighbours.Sep 21 2023, 11:10 AM

kp added a commit: rGa9326cd7656b: ndp: cope with unresolved neighbours.Sep 21 2023, 12:00 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

ndp/

ndp_netlink.c

7 lines

Diff 127510

View Options

usr.sbin/ndp/ndp_netlink.c

ndp: cope with unresolved neighboursClosedPublicActions