Skip known safe Spectre-V4 arm64 CPUs
Needs ReviewPublic
Actions

Authored by andrew on Sep 12 2023, 3:28 PM.

Details

Reviewers

manu
emaste

Group Reviewers

arm64

Summary

There is no need to search for the Spectre-V4 workaround handler on
the Cortex-A35, A53, or A55 CPUs as these are known to not be
vulnerable. Exit early on these CPUs rather than probe to the
workaround.

While here print a message when the workaround was forced on, but no
firmware support was found.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 53570
Build 50461: arc lint + arc unit

Event Timeline

andrew created this revision.Sep 12 2023, 3:28 PM

Herald added a reviewer: manu. · View Herald TranscriptSep 12 2023, 3:28 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Sep 12 2023, 3:28 PM

Harbormaster completed remote builds in B53550: Diff 127284.Sep 12 2023, 3:28 PM

andrew added a parent revision: D41830: Restrict when we install arm64 spectre-v2 errata.Sep 12 2023, 3:28 PM

andrew added a child revision: D41832: arm64: Use FEAT_SSBS as a Spectre-V4 workaround.

emaste accepted this revision as: emaste.Sep 13 2023, 11:05 AM

emaste added inline comments.

sys/arm64/arm64/cpu_errata.c
148	maybe include `kern.cfg.ssbd` to give a hint about why it's forced on?

This revision is now accepted and ready to land.Sep 13 2023, 11:05 AM

Update the force-on warning

This revision now requires review to proceed.Sep 13 2023, 12:13 PM

Harbormaster completed remote builds in B53570: Diff 127328.Sep 13 2023, 12:13 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

cpu_errata.c

21 lines

Diff 127328

View Options

sys/arm64/arm64/cpu_errata.c

Skip known safe Spectre-V4 arm64 CPUsNeeds ReviewPublicActions