Page MenuHomeFreeBSD

Mk/Uses: autoreconf.mk: Add AUTORECONF_ARGS
ClosedPublic

Authored by otis on Feb 10 2023, 9:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 23, 2:28 AM
Unknown Object (File)
Sun, Jun 23, 2:22 AM
Unknown Object (File)
Fri, Jun 21, 2:48 AM
Unknown Object (File)
May 25 2024, 11:27 AM
Unknown Object (File)
May 11 2024, 6:49 PM
Unknown Object (File)
May 4 2024, 4:11 AM
Unknown Object (File)
Apr 30 2024, 4:02 PM
Unknown Object (File)
Apr 28 2024, 12:37 PM

Details

Summary

Add AUTORECONF_ARGS variable for situations where the default of -f -i is not sufficient.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 53565
Build 50456: arc lint + arc unit

Event Timeline

otis requested review of this revision.Feb 10 2023, 9:19 PM
Mk/Uses/autoreconf.mk
81

Why not AUTORECONF_FLAGS+= -f -i

We keep forcing -f -i because we always want that, but we allow the user to define its own flags before inclusion of the USES
at worst we will end up with duplicating -f and -i which I think is fine.

Mk/Uses/autoreconf.mk
130

I would name the variable AUTORECONF_ARGS and put it after the -f -i here. Then document it above as "Extra arguments to autoreconf. Default: none". Then port maintainers can still pass --no-force or --no-install if needed and pass arguments other than flags such as a list of directories.

otis marked 2 inline comments as done.Sep 13 2023, 8:49 AM
otis retitled this revision from Mk/Uses: autoreconf.mk: Add AUTORECONF_FLAGS to Mk/Uses: autoreconf.mk: Add AUTORECONF_ARGS.Sep 13 2023, 8:52 AM
otis edited the summary of this revision. (Show Details)
otis edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Sep 14 2023, 11:49 AM
This revision was automatically updated to reflect the committed changes.