Page MenuHomeFreeBSD

cat: report copy_file_range() errors with the read filename
ClosedPublic

Authored by kevans on Sep 8 2023, 4:19 PM.
Tags
None
Referenced Files
F162930860: D41784.id.diff
Sat, Jul 18, 10:22 AM
Unknown Object (File)
Sun, Jul 12, 12:15 AM
Unknown Object (File)
Mon, Jul 6, 4:20 AM
Unknown Object (File)
Sat, Jul 4, 1:36 PM
Unknown Object (File)
Fri, Jul 3, 12:51 AM
Unknown Object (File)
Wed, Jul 1, 8:26 AM
Unknown Object (File)
Tue, Jun 30, 6:40 AM
Unknown Object (File)
Sun, Jun 28, 4:46 AM
Subscribers

Details

Summary

The error may be due to an error while writing, but it's more helpful to
report what we were trying to from rather than "stdout" for these
errors. Noticed because of what happens now when cat gets an EISDIR
for reading from a dirfd:

kevans@ifrit:~$ cat /etc
cat: stdout: Is a directory

which, after this change, becomes:

kevans@aarch64-dev:~$ cat /etc
cat: /etc: Is a directory

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53506
Build 50397: arc lint + arc unit