Paths

Table of Contentst

Differential D41306

tzsetup: add support for countries in two continents
ClosedPublic
Actions

Authored by khorben on Aug 3 2023, 8:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 25, 2:10 PM

	Unknown Object (File)
	Mon, Nov 3, 8:26 PM

	Unknown Object (File)
	Fri, Oct 31, 12:26 PM

	Unknown Object (File)
	Thu, Oct 30, 4:11 AM

	Unknown Object (File)
	Wed, Oct 29, 2:55 PM

	Unknown Object (File)
	Wed, Oct 29, 12:11 PM

	Unknown Object (File)
	Wed, Oct 29, 11:53 AM

	Unknown Object (File)
	Wed, Oct 29, 11:53 AM

Subscribers

Details

Reviewers

emaste
khorben
bapt

Commits

rGc886dfb048f9: tzsetup: add support for countries in two continents
rG9ef162b2392f: tzsetup: add support for countries in two continents
rG914ab28c598c: tzsetup: add support for countries in two continents

Summary

This supports countries located across multiple continents, as per the zone1970.tab file. This only affects Cyprus and Türkiye at the moment.

The patch only handles a single extra continent, even though the file format supports multiple ones; in practice this capability is not used in zone1970.tab as of today. Therefore I believe this change is a net positive for now, as it fixes an issue reported by a user from Cyprus.

PR: #236874
Sponsored by: The FreeBSD Foundation

Test Plan

$ make buildenv
$ cd usr.sbin/tzsetup
$ make
$ /usr/obj/usr/src/usr.sbin/tzsetup/tzsetup
[browse through Asia and Europe, both should list Cyprus and Türkiye]

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

khorben created this revision.Aug 3 2023, 8:38 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 3 2023, 8:38 PM

khorben requested review of this revision.Aug 3 2023, 8:38 PM

Harbormaster completed remote builds in B52965: Diff 125537.Aug 3 2023, 8:38 PM

khorben edited the test plan for this revision. (Show Details)Aug 3 2023, 8:40 PM

asiciliano added a subscriber: asiciliano.Aug 4 2023, 2:41 PM

khorben added a reviewer: emaste.Aug 7 2023, 1:51 PM

This looks reasonable overall

usr.sbin/tzsetup/tzsetup.c
281	"extra" continent isn't obvious to me -- maybe "alternate"?
475–477	might be worth a `switch` now that we have 3 cases

khorben updated this revision to Diff 126687.Aug 30 2023, 6:18 PM

This comment was removed by khorben.

Renamed the new member of struct country
Use a switch/case for pass 1 to 3

khorben accepted this revision.Aug 30 2023, 6:23 PM

khorben marked 2 inline comments as done.

This revision is now accepted and ready to land.Aug 30 2023, 6:23 PM

khorben added a reviewer: bapt.Oct 12 2023, 9:24 PM

I fetched this from your branch but it still has struct continent *extra; /* extra continent */ (not alternate), please refresh.

I rebased and updated the commit with the full message at https://github.com/khorben/freebsd-src/tree/khorben/tzsetup-extra.

Closed by commit rG914ab28c598c: tzsetup: add support for countries in two continents (authored by khorben, committed by emaste). · Explain WhyOct 13 2023, 5:25 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG914ab28c598c: tzsetup: add support for countries in two continents.

emaste added a commit: rG9ef162b2392f: tzsetup: add support for countries in two continents.Oct 16 2023, 12:32 PM

emaste added a commit: rGc886dfb048f9: tzsetup: add support for countries in two continents.Oct 16 2023, 10:50 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

tzsetup/

67 lines

Diff 126688

usr.sbin/tzsetup/tzsetup.c

Loading...