Page MenuHomeFreeBSD
Differential D41604

audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on ARCHes other than x86
ClosedPublic
Actions

Authored by vvd on Aug 26 2023, 5:48 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 23, 12:58 PM
Unknown Object (File)
Oct 8 2024, 1:20 PM
Unknown Object (File)
Sep 27 2024, 6:26 PM
Unknown Object (File)
Sep 27 2024, 3:55 AM
Unknown Object (File)
Sep 27 2024, 3:54 AM
Unknown Object (File)
Sep 27 2024, 3:54 AM
Unknown Object (File)
Sep 26 2024, 10:58 PM
Unknown Object (File)
Sep 26 2024, 7:19 PM
View All 89 Files
Subscribers
diizzy
fuz
jhale
pkubaj

Details

Reviewers
arrowd
tcberner
adamw
Commits
R11:3553d5df611e: audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on…
R11:08c1696fb18e: audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on…
Summary
  1. Switch from USE_GITHUB to pre-rolled release.
  2. Use CMake to install the files instead of using custom do-install target.
  3. Unbundle devel/microsoft-gsl.
  4. Fix build and keep possibility to build 32bit overlay on other ARCHes than x86.
  5. "Pet portclippy".

PR:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=273203
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=272881

Tested build in poudriere on 12.4, 13.2 amd64 and i386. Tested work on 13.2 amd64.

Ideas, patches and testing: fuz@, jhale@, pkubaj@.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vvd requested review of this revision.Aug 26 2023, 5:48 PM
vvd created this revision.
diizzy added a subscriber: diizzy.Aug 27 2023, 6:23 AM
diizzy added inline comments.
audio/mumble/Makefile
9

+= should be =

40

Where is this used?

48

+= --> =

vvd updated this revision to Diff 126564.Aug 27 2023, 12:56 PM
vvd marked 3 inline comments as done.Aug 27 2023, 12:58 PM
vvd added inline comments.
audio/mumble/Makefile
40

File auxiliary_files/run_scripts/mumble-overlay.in installed as bin/mumble-overlay.
Check pkg-plist.

vvd marked an inline comment as done.Aug 27 2023, 1:00 PM
vvd updated this revision to Diff 126596.Aug 28 2023, 3:48 PM
vvd updated this revision to Diff 126600.Aug 28 2023, 5:51 PM

Replaced shebang with statically patch.

tcberner added inline comments.Aug 28 2023, 6:30 PM
audio/mumble/files/patch-auxiliary__files_run__scripts_mumble-overlay.in
19

^ thanks, I think this is much cleaner this way than when using shebangfix -- as you already have a nice comment above about removing bash :)

tcberner accepted this revision.Aug 28 2023, 6:31 PM

This looks good to me.

This revision is now accepted and ready to land.Aug 28 2023, 6:31 PM
Closed by commit R11:08c1696fb18e: audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on… (authored by vvd). · Explain WhyAug 28 2023, 6:56 PM
This revision was automatically updated to reflect the committed changes.
vvd added a commit: R11:08c1696fb18e: audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on….
vvd added a commit: R11:3553d5df611e: audio/mumble: switch from USE_GITHUB to pre-rolled release and fix build on….Aug 28 2023, 7:10 PM

Revision Contents
Changeset List

Diff 126596

View Options

audio/mumble/Makefile

Loading...
View Options

audio/mumble/distinfo

Loading...
View Options

audio/mumble/files/patch-auxiliary__files_run__scripts_mumble-overlay.in

Loading...
View Options

audio/mumble/files/patch-overlay__gl_CMakeLists.txt

Loading...
View Options

audio/mumble/pkg-plist

Loading...