Page MenuHomeFreeBSD
Differential D41614

geli: fix setkey behavior on detached providers
Needs ReviewPublic
Actions

Authored by freebsd_igalic.co on Aug 28 2023, 10:06 AM.
Tags
Referenced Files
F173958691: D41614.diff
Tue, Sep 29, 3:50 PM
Unknown Object (File)
Tue, Sep 29, 10:50 AM
Unknown Object (File)
Fri, Sep 25, 3:33 AM
Unknown Object (File)
Thu, Sep 24, 10:55 PM
Unknown Object (File)
Thu, Sep 24, 10:47 AM
Unknown Object (File)
Thu, Sep 10, 6:13 PM
Unknown Object (File)
Tue, Sep 8, 1:12 PM
Unknown Object (File)
Tue, Sep 8, 2:25 AM
View All Files
Subscribers
delphij
imp
markj

Details

Reviewers
None
Group Reviewers
secteam
security
Summary

wipe out cached_passphrase (using memset(3), for clarity) to allow
geil(8) setkey to correctly function on detached providers.

PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254966
Reported by: rob2g2
Submitted by: Arjan de Vet <freebsd@devet.org>
Pull Request: https://github.com/freebsd/freebsd-src/pull/780

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 53314
Build 50205: arc lint + arc unit

Event Timeline

freebsd_igalic.co created this revision.Aug 28 2023, 10:06 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 28 2023, 10:06 AM
freebsd_igalic.co requested review of this revision.Aug 28 2023, 10:06 AM
Harbormaster completed remote builds in B53314: Diff 126577.Aug 28 2023, 10:06 AM
freebsd_igalic.co added reviewers: secteam, security.Aug 28 2023, 10:12 AM
freebsd_igalic.co added projects: secteam, security.
delphij added a subscriber: delphij.Aug 29 2023, 4:03 AM

The change looks Okay to me but I wonder if we should separate the variable into two cached values, one for new and the other for !new.

When changing multiple providers at the same time, this would allow the library to cache both passphrases so the user don't have to enter them over and over again.

markj added a subscriber: markj.EditedAug 29 2023, 1:35 PM
In D41614#948592, @delphij wrote:

The change looks Okay to me but I wonder if we should separate the variable into two cached values, one for new and the other for !new.

When changing multiple providers at the same time, this would allow the library to cache both passphrases so the user don't have to enter them over and over again.

I already committed a similar change with a regression test: 88d13bf33754bd4b0c5df92eef83d6fadb9b4944 and 2b7b09ac9675023869fddbae4911c9b674b1155a.

I think your suggestion is a good one, but it also makes sense to commit a simple fix now since this was a regression and we'd like to fix it in 14.0.

Revision Contents
Changeset List

PathSize
lib/
geom/
eli/
6 lines

Diff 126577

View Options

lib/geom/eli/geom_eli.c

Loading...