cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions
ClosedPublic
Actions

Authored by jhb on Jul 31 2023, 10:26 PM.

Details

Reviewers

imp
mav

Group Reviewers

cam

Commits

rG0a57cdd971b2: cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions

Summary

Use an sbuf that drains to printf to avoid duplicating code in the two
versions of each function.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52919
Build 49810: arc lint + arc unit

Event Timeline

jhb created this revision.Jul 31 2023, 10:26 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 31 2023, 10:26 PM

jhb requested review of this revision.Jul 31 2023, 10:26 PM

Harbormaster completed remote builds in B52919: Diff 125401.Jul 31 2023, 10:26 PM

jhb added a parent revision: D41262: cam_xpt: Remove fallbacks for non-sbuf protocol methods.Jul 31 2023, 10:26 PM

jhb added a child revision: D41264: cam: Remove non-sbuf announce/denounce proto and xport ops.

jhb added a parent revision: D41177: cam xpt_*nounce_periph*: Various fixes for periphs without a protocol.Jul 31 2023, 10:28 PM

mav accepted this revision.Aug 1 2023, 3:12 PM

This revision is now accepted and ready to land.Aug 1 2023, 3:12 PM

Closed by commit rG0a57cdd971b2: cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions (authored by jhb). · Explain WhyAug 1 2023, 10:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0a57cdd971b2: cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions.

Revision Contents
Changeset List

Path

Size

sys/

cam/

cam_xpt.c

68 lines

Diff 125401

View Options

cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versionsClosedPublicActions