Differential D41263

cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions
ClosedPublic
Actions

Authored by jhb on Jul 31 2023, 10:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 22, 4:02 AM

	Unknown Object (File)
	Tue, Jul 21, 8:38 PM

	Unknown Object (File)
	Tue, Jul 21, 8:32 AM

	Unknown Object (File)
	Jun 11 2026, 3:08 PM

	Unknown Object (File)
	Jun 11 2026, 11:20 AM

	Unknown Object (File)
	Jun 10 2026, 8:55 PM

	Unknown Object (File)
	Jun 8 2026, 4:54 AM

	Unknown Object (File)
	May 15 2026, 1:36 AM

Subscribers

None

Details

Reviewers

imp
mav

Group Reviewers

Commits

rG0a57cdd971b2: cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions

Summary

Use an sbuf that drains to printf to avoid duplicating code in the two
versions of each function.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 31 2023, 10:26 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 31 2023, 10:26 PM

jhb requested review of this revision.Jul 31 2023, 10:26 PM

Harbormaster completed remote builds in B52919: Diff 125401.Jul 31 2023, 10:26 PM

jhb added a parent revision: D41262: cam_xpt: Remove fallbacks for non-sbuf protocol methods.Jul 31 2023, 10:26 PM

jhb added a child revision: D41264: cam: Remove non-sbuf announce/denounce proto and xport ops.

jhb added a parent revision: D41177: cam xpt_*nounce_periph*: Various fixes for periphs without a protocol.Jul 31 2023, 10:28 PM

mav accepted this revision.Aug 1 2023, 3:12 PM

This revision is now accepted and ready to land.Aug 1 2023, 3:12 PM

Closed by commit rG0a57cdd971b2: cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions (authored by jhb). · Explain WhyAug 1 2023, 10:28 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0a57cdd971b2: cam_xpt: Reimplement xpt_*nounce_periph in terms of the _sbuf versions.

Revision Contents
Changeset List

Path

Size

sys/

cam/

68 lines

Diff 125469

sys/cam/cam_xpt.c

Loading...