Differential D41176

cam/nvme: Remove spurious newline during periph detach announcement
ClosedPublic
Actions

Authored by jhb on Jul 25 2023, 6:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	May 2 2024, 2:05 PM

	Unknown Object (File)
	May 2 2024, 2:05 PM

	Unknown Object (File)
	May 2 2024, 2:05 PM

	Unknown Object (File)
	May 2 2024, 9:04 AM

	Unknown Object (File)
	Mar 19 2024, 4:17 AM

	Unknown Object (File)
	Mar 19 2024, 4:17 AM

	Unknown Object (File)
	Mar 19 2024, 4:17 AM

	Unknown Object (File)
	Mar 14 2024, 4:09 PM

View All 15 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG0be27bde5f67: cam/nvme: Remove spurious newline during periph detach announcement

Summary

Other protocol denounce routines use a "short" variant of announce
that does not include a trailing newline.

Sponsored by: Chelsio Communications

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 25 2023, 6:46 PM

Herald added a reviewer: cam. · View Herald TranscriptJul 25 2023, 6:46 PM

Herald added a subscriber: dab. · View Herald Transcript

jhb requested review of this revision.Jul 25 2023, 6:46 PM

Harbormaster completed remote builds in B52822: Diff 125136.Jul 25 2023, 6:46 PM

Before:

nda0: 1024MB (2097152 512 byte sectors)
nda0 at nvme0 bus 0 scbus0 target 0 lun 1
nda0: <Linux 5.15.0-7 7c0d1737fc54fb6b6b7b>
 s/n 7c0d1737fc54fb6b6b7b detached
(nda0:nvme0:0:0:1): Periph destroyed
nvme0: detached

After:

nda0: 1024MB (2097152 512 byte sectors)
nda0 at nvme0 bus 0 scbus0 target 0 lun 1
nda0: <Linux 5.15.0-7 7c0d1737fc54fb6b6b7b> s/n 7c0d1737fc54fb6b6b7b detached
(nda0:nvme0:0:0:1): Periph destroyed
nvme0: detached

(This doesn't do anything about the serial number being printed twice..)

jhb mentioned this in D41177: cam xpt_*nounce_periph*: Various fixes for periphs without a protocol.Jul 25 2023, 7:10 PM

imp added inline comments.Jul 25 2023, 11:21 PM

sys/cam/nvme/nvme_all.c
109	This should likely be firmware version to match the other drivers

jhb added inline comments.Jul 26 2023, 8:51 PM

sys/cam/nvme/nvme_all.c
109	I'm not quite sure I follow, you want to reorder the fields? (And if so, that's fine, but probably as a separate commit from this)

jhb added a child revision: D41261: cam mmc_xpt/nvme_xpt: Add _sbuf variants of {an,de}nounce xport and proto ops.Jul 31 2023, 10:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 1 2023, 10:27 PM

Closed by commit rG0be27bde5f67: cam/nvme: Remove spurious newline during periph detach announcement (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG0be27bde5f67: cam/nvme: Remove spurious newline during periph detach announcement.

Revision Contents
Changeset List

Path

Size

sys/

cam/

nvme/

2 lines

9 lines

7 lines

Diff 125464

sys/cam/nvme/nvme_all.h

Loading...

sys/cam/nvme/nvme_all.c

Loading...

sys/cam/nvme/nvme_xpt.c

Loading...