tools/build: Work around broken Clang FreeBSD resource dir logic pre-13
ClosedPublic
Actions

Authored by jrtc27 on Jul 31 2023, 1:18 AM.

Details

Reviewers

Commits

rG01718a2e94da: tools/build: Work around broken Clang FreeBSD resource dir logic pre-13

Summary

Prior to Clang 13 (e.g. in the Clang 11 present in 13.0-RELEASE), the
resource directory logic for FreeBSD was broken and would not resolve
symlinks, meaning symlinks would only work if in a directory next to the
containing lib directory. Therefore we cannot even use a symlink for
worldtmp, we have to make a wrapper script that execs the real binary
via an absolute path.

Reported by: markj
Fixes: 65f28f63a73d ("tools/build: Create toolchain symlinks for non-absolute compiler/linker")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Jul 31 2023, 1:18 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 31 2023, 1:18 AM

jrtc27 requested review of this revision.Jul 31 2023, 1:18 AM

Harbormaster completed remote builds in B52894: Diff 125352.Jul 31 2023, 1:18 AM

Thanks, this fixes the build error for me.

The diff seems reasonable, though pushing each compiler invocation through this wrapper might have a measurable cost. Though, that only affects the first portion of the world build I think? Would it make sense to limit the workaround to clang before version 13?

This revision is now accepted and ready to land.Jul 31 2023, 1:47 AM

Limit hack to Clang < 13

This revision now requires review to proceed.Jul 31 2023, 1:56 AM

Harbormaster completed remote builds in B52895: Diff 125354.Jul 31 2023, 1:57 AM

In D41238#939257, @markj wrote:

Thanks, this fixes the build error for me.

The diff seems reasonable, though pushing each compiler invocation through this wrapper might have a measurable cost. Though, that only affects the first portion of the world build I think? Would it make sense to limit the workaround to clang before version 13?

Depends if you force world to be built with the system compiler or not, as I believe it'll end up using the wrappers in that case. Regardless, it's easy enough to limit it, which seems like a good thing to do for this kind of hack.

This version works for me too.

This revision is now accepted and ready to land.Jul 31 2023, 12:53 PM

Closed by commit rG01718a2e94da: tools/build: Work around broken Clang FreeBSD resource dir logic pre-13 (authored by jrtc27). · Explain WhyJul 31 2023, 5:28 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG01718a2e94da: tools/build: Work around broken Clang FreeBSD resource dir logic pre-13.