Page MenuHomeFreeBSD
Differential D4969

Add "kldstat -h"; showing module sizes in hex is rather weird.
ClosedPublic
Actions

Authored by trasz on Jan 17 2016, 9:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 3:46 PM
Unknown Object (File)
Mon, Nov 11, 1:05 AM
Unknown Object (File)
Fri, Nov 1, 8:59 AM
Unknown Object (File)
Oct 15 2024, 6:33 AM
Unknown Object (File)
Oct 4 2024, 10:56 AM
Unknown Object (File)
Oct 3 2024, 10:10 AM
Unknown Object (File)
Oct 2 2024, 3:58 AM
Unknown Object (File)
Oct 1 2024, 3:57 PM
View All Files
Subscribers
imp

Details

Reviewers
emaste
Group Reviewers
manpages
Commits
rS294624: Add "kldstat -h"; showing module sizes in hex is rather weird.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2197
Build 2206: arc lint + arc unit

Event Timeline

trasz updated this revision to Diff 12395.Jan 17 2016, 9:28 PM
trasz retitled this revision from to Add "kldstat -h"; showing module sizes in hex is rather weird..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptJan 17 2016, 9:28 PM
trasz added a reviewer: emaste.Jan 17 2016, 9:28 PM
emaste edited edge metadata.Jan 18 2016, 12:01 AM

kldstat.8 update?

trasz updated this revision to Diff 12419.Jan 18 2016, 2:43 PM
trasz edited edge metadata.

Update manual page, and drop the "-h" from usage() in one case it doesn't apply.

Herald added a reviewer: manpages. · View Herald TranscriptJan 18 2016, 2:43 PM
emaste accepted this revision.Jan 18 2016, 8:24 PM
emaste edited edge metadata.

Looks good other than two minor comments

sbin/kldstat/kldstat.8
53

I believe for standard manpage style this should something like "Display the size field in a human-readable form..."

sbin/kldstat/kldstat.c
39–40

any reason this shouldn't sort in with the other headers?

68–70

fwiw I think it's better in these cases to always use the temporary buf, so that there aren't two strings that could get out of sync

This revision is now accepted and ready to land.Jan 18 2016, 8:24 PM
trasz updated this revision to Diff 12467.Jan 19 2016, 12:37 PM
trasz edited edge metadata.

More input from emaste@.

This revision now requires review to proceed.Jan 19 2016, 12:37 PM
Herald edited edge metadata. · View Herald TranscriptJan 19 2016, 12:37 PM
emaste accepted this revision.Jan 19 2016, 3:00 PM
emaste edited edge metadata.

LGTM with two nits

sbin/kldstat/kldstat.c
59

buf[6] now too small for %-8zx format string

69

note that there's a %-8s in the printf below so this shouldn't need any width/alignment set explicitly

This revision is now accepted and ready to land.Jan 19 2016, 3:00 PM
trasz updated this revision to Diff 12473.Jan 19 2016, 5:51 PM
trasz edited edge metadata.

Improve formatting - the "-h" output looks much better now - and go
back to two separate printfs.

This revision now requires review to proceed.Jan 19 2016, 5:51 PM
Herald edited edge metadata. · View Herald TranscriptJan 19 2016, 5:51 PM
Closed by commit rS294624: Add "kldstat -h"; showing module sizes in hex is rather weird. (authored by trasz). · Explain WhyJan 23 2016, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
kldstat/
2 lines
6 lines
39 lines

Diff 12473

View Options

sbin/kldstat/Makefile

Loading...
View Options

sbin/kldstat/kldstat.8

Loading...
View Options

sbin/kldstat/kldstat.c

Loading...