Details
Details
- Reviewers
- emaste 
- Group Reviewers
- manpages 
- Commits
- rS294624: Add "kldstat -h"; showing module sizes in hex is rather weird.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
- Lint Passed 
- Unit
- No Test Coverage 
- Build Status
- Buildable 2169 - Build 2178: arc lint + arc unit 
Event Timeline
Comment Actions
Looks good other than two minor comments
| sbin/kldstat/kldstat.8 | ||
|---|---|---|
| 53 | I believe for standard manpage style this should something like "Display the size field in a human-readable form..." | |
| sbin/kldstat/kldstat.c | ||
| 38–39 | any reason this shouldn't sort in with the other headers? | |
| 69–71 | fwiw I think it's better in these cases to always use the temporary buf, so that there aren't two strings that could get out of sync | |
Comment Actions
Improve formatting - the "-h" output looks much better now - and go
back to two separate printfs.