Page MenuHomeFreeBSD

databases/akonadi and net-im/kaccounts-integration: reverse dependencies
ClosedPublic

Authored by vvd on Jul 13 2023, 4:40 PM.
Tags
Referenced Files
Unknown Object (File)
Fri, Sep 27, 2:35 PM
Unknown Object (File)
Thu, Sep 26, 4:28 PM
Unknown Object (File)
Mon, Sep 23, 11:02 PM
Unknown Object (File)
Mon, Sep 23, 6:46 AM
Unknown Object (File)
Sun, Sep 22, 11:15 PM
Unknown Object (File)
Aug 17 2024, 11:19 PM
Unknown Object (File)
Aug 12 2024, 6:17 AM
Unknown Object (File)
Aug 12 2024, 5:34 AM
Subscribers

Details

Summary

Tested build in live system and poudriere 13.2 amd64.

Without this patch, there is a circular dependency if Akonadi is built with kaccounts-integration installed, as Akonadi has an optional dependency on kaccounts-integration and libaccounts-qt5 that makes the port silently depend on libkaccounts.so and libaccounts-qt5.so. kaccounts-integration, on the other hand, had a dependency on Akonadi that was probably inherited from the Qt4 version, as the Akonadi plugin was removed from the code base in 2015.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

vvd requested review of this revision.Jul 13 2023, 4:40 PM
vvd created this revision.

The change seems to make sense -- the Akonadi plugin in kaccounts was disabled in 2015, and the optional KAccounts integration in Akonadi landed in 2019.

With that said, the reorganization of the entries in USES/USE_* is very confusing to follow. Please consider doing that separately or just leaving the entries untouched (modulo removing "akonadi" from USE_KDE in kaccounts-integration, of course), ugly as they are.

vvd edited the summary of this revision. (Show Details)

Removed sorting USES in patch.
Added short description in summary - was discussed in IRC (#freebsd-desktop @ Libera.Chat).

This version looks better, thanks. I've proof-read the description and added some more information, feel free to change it as you see fit.

I'll leave it to someone else to approve the patch though, as my kde@ hat is quite dusty at this point.

This revision is now accepted and ready to land.Jul 14 2023, 4:24 AM