libbe: bail out early if the zfs kmod isn't loaded
ClosedPublic
Actions

Authored by kevans on Aug 13 2022, 12:22 AM.

Details

Reviewers

allanjude
cperciva
rew
jwmaag_gmail.com

Commits

rG2f700ca965a0: libbe: bail out early if the zfs kmod isn't loaded

Summary

As noted in the comment, we already know the rest of libbe_init() will
fail because there's no pool imported. Avoid the side effect by
checking beforehand and bailing out early.

With this, freebsd-update(8) should no longer trigger a load of the zfs
kmod just because it runs bectl check.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Aug 13 2022, 12:22 AM

Herald added a subscriber: imp. · View Herald TranscriptAug 13 2022, 12:22 AM

Harbormaster completed remote builds in B46917: Diff 109282.Aug 13 2022, 12:22 AM

kevans requested review of this revision.Aug 13 2022, 12:22 AM

rew accepted this revision.Aug 14 2022, 3:37 AM

This revision is now accepted and ready to land.Aug 14 2022, 3:37 AM

jwmaag_gmail.com accepted this revision.Aug 16 2022, 1:48 AM

Closed by commit rG2f700ca965a0: libbe: bail out early if the zfs kmod isn't loaded (authored by kevans). · Explain WhyJul 7 2023, 12:41 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG2f700ca965a0: libbe: bail out early if the zfs kmod isn't loaded.

Revision Contents
Changeset List

Path

Size

lib/

libbe/

be.c

11 lines

Diff 124263

View Options

libbe: bail out early if the zfs kmod isn't loadedClosedPublicActions