Page MenuHomeFreeBSD
Differential D40829

riscv: improve register dumping
ClosedPublic
Actions

Authored by christos on Jul 1 2023, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 30, 9:30 AM
Unknown Object (File)
Mon, Mar 30, 7:37 AM
Unknown Object (File)
Mon, Mar 30, 1:07 AM
Unknown Object (File)
Sun, Mar 29, 3:34 AM
Unknown Object (File)
Sat, Mar 28, 4:00 AM
Unknown Object (File)
Tue, Mar 24, 5:43 AM
Unknown Object (File)
Sun, Mar 22, 6:34 PM
Unknown Object (File)
Wed, Mar 11, 1:18 PM
View All Files
Subscribers
imp
riscv

Details

Reviewers
markj
mhorne
jhb
Commits
rG1c776124513c: riscv: improve register dumping
Summary

Search for and print kernel symbols in case a register's value is a
kernel address. Also improve column alignment.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Jul 1 2023, 6:54 PM
Herald added subscribers: riscv, imp. · View Herald TranscriptJul 1 2023, 6:54 PM
christos requested review of this revision.Jul 1 2023, 6:54 PM
Harbormaster completed remote builds in B52373: Diff 124073.Jul 1 2023, 6:54 PM
jhb accepted this revision.Jul 1 2023, 9:06 PM
This revision is now accepted and ready to land.Jul 1 2023, 9:06 PM
christos added a comment.Jul 2 2023, 3:06 AM

Sample output:

   t[0]: 0x0000000000000000
   t[1]: 0x0000000000000000
   t[2]: 0x0000000000000008
   t[3]: 0x00ff000000000000
   t[4]: 0x000000000000ff00
   t[5]: 0xfefefefefefefeff
   t[6]: 0x8080808080808080
   s[0]: 0xffffffc095566770 (end + 0x94a8b158)
   s[1]: 0x0000000551bae478
   s[2]: 0x0000000551bae490
   s[3]: 0xffffffc095756280 (end + 0x94c7ac68)
   s[4]: 0xffffffc0955668a8 (end + 0x94a8b290)
   s[5]: 0xffffffc095566988 (end + 0x94a8b370)
   s[6]: 0xffffffd003181538
   s[7]: 0x0000000000000000
   s[8]: 0x0000000000000000
   s[9]: 0x0000000000000000
  s[10]: 0x0000000000200400
  s[11]: 0xffffffffffffffff
   a[0]: 0xffffffc04ad0e008 (end + 0x4a2329f0)
   a[1]: 0x0000000551bae478
   a[2]: 0x0000000000000013
   a[3]: 0x0000000551bae48b
   a[4]: 0x62696c2f7273752f
   a[5]: 0xffffffc04ad0e008 (end + 0x4a2329f0)
   a[6]: 0xffffffc0005b6630 (copyio_fault + 0x0)
   a[7]: 0x0000000000040000
     ra: 0xffffffc0002bab70 (exec_copyout_strings + 0x80)
     sp: 0xffffffc0955666c0 (end + 0x94a8b0a8)
     gp: 0xffffffc095566610 (end + 0x94a8aff8)
     tp: 0xffffffc000ad5380 (__pcpu + 0x100)
   sepc: 0xffffffc0005b66ac (copyout + 0x5c)
sstatus: 0x8000000200046120
mhorne accepted this revision.Jul 3 2023, 4:16 PM

Thanks, this is a nice improvement.

sys/riscv/riscv/trap.c
138

Consider giving this function a name that include "print", for example, print_with_symbol().

christos updated this revision to Diff 124134.Jul 3 2023, 5:00 PM
christos marked an inline comment as done.

Address Mitchell's comment.

This revision now requires review to proceed.Jul 3 2023, 5:00 PM
Harbormaster completed remote builds in B52408: Diff 124134.Jul 3 2023, 5:00 PM
mhorne accepted this revision.Jul 3 2023, 5:07 PM
This revision is now accepted and ready to land.Jul 3 2023, 5:07 PM
markj added a comment.Jul 4 2023, 2:31 PM

Approved.

Closed by commit rG1c776124513c: riscv: improve register dumping (authored by christos). · Explain WhyJul 4 2023, 3:40 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG1c776124513c: riscv: improve register dumping.

Revision Contents
Changeset List

PathSize
sys/
riscv/
riscv/
67 lines

Diff 124175

View Options

sys/riscv/riscv/trap.c

Loading...