Page MenuHomeFreeBSD
Differential D40848

VFS lookup: compute_lk_cnflags(): Remove unused argument 'cnflags'; Rename
ClosedPublic
Actions

Authored by olce on Jul 3 2023, 12:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 4:51 AM
Unknown Object (File)
Thu, Aug 13, 4:51 AM
Unknown Object (File)
Thu, Aug 13, 4:51 AM
Unknown Object (File)
Thu, Aug 13, 4:51 AM
Unknown Object (File)
Wed, Aug 12, 9:31 PM
Unknown Object (File)
Wed, Aug 12, 1:43 PM
Unknown Object (File)
Mon, Aug 10, 9:04 AM
Unknown Object (File)
Mon, Aug 10, 2:22 AM
View All Files
Subscribers
imp

Details

Reviewers
jah
mjg
kib
markj
Commits
rG5842f73dbc2a: vfs: compute_lk_cnflags(): Remove unused argument 'cnflags'; Rename
Summary

Argument unused since commit 93a0ba8f4990785f.

Rename it to enforce_lkflags(), which seems to more aptly describe what it does.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 52398
Build 49289: arc lint + arc unit

Event Timeline

olce created this revision.Jul 3 2023, 12:53 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 3 2023, 12:53 PM
olce requested review of this revision.Jul 3 2023, 12:53 PM
Harbormaster completed remote builds in B52398: Diff 124118.Jul 3 2023, 12:53 PM
olce added a parent revision: D40847: dounmount(): Acquire covered vnode lock after draining mount point references.Jul 3 2023, 1:03 PM
olce added a child revision: D40849: vrele(): Never block trying to acquire an exclusive vnode lock.
markj accepted this revision.Jul 4 2023, 4:01 PM
This revision is now accepted and ready to land.Jul 4 2023, 4:01 PM
kib accepted this revision.Jul 4 2023, 5:59 PM
mjg accepted this revision.Jul 5 2023, 1:39 PM

weird, why does not clang complain about it?

Closed by commit rG5842f73dbc2a: vfs: compute_lk_cnflags(): Remove unused argument 'cnflags'; Rename (authored by olce, committed by mjg). · Explain WhyJul 5 2023, 1:46 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rG5842f73dbc2a: vfs: compute_lk_cnflags(): Remove unused argument 'cnflags'; Rename.
olce edited child revisions, added: D40850: VFS lookup: New vn_cross_single_mount() and vn_cross_mounts(); removed: D40849: vrele(): Never block trying to acquire an exclusive vnode lock.Jul 7 2023, 6:55 AM
olce removed a child revision: D40850: VFS lookup: New vn_cross_single_mount() and vn_cross_mounts().Jul 7 2023, 6:58 AM
olce removed a parent revision: D40847: dounmount(): Acquire covered vnode lock after draining mount point references.

Revision Contents
Changeset List

PathSize
sys/
kern/
23 lines

Diff 124118

View Options

sys/kern/vfs_lookup.c

Loading...