Details

sbin/kldstat/kldstat.8
53 ↗	(On Diff #12419)	I believe for standard manpage style this should something like "Display the size field in a human-readable form..."
sbin/kldstat/kldstat.c
38–41	any reason this shouldn't sort in with the other headers?
69–71	fwiw I think it's better in these cases to always use the temporary buf, so that there aren't two strings that could get out of sync

This revision is now accepted and ready to land.Jan 18 2016, 8:24 PM

More input from emaste@.

This revision now requires review to proceed.Jan 19 2016, 12:37 PM

LGTM with two nits

sbin/kldstat/kldstat.c
60	`buf[6]` now too small for %-8zx format string
70	note that there's a %-8s in the printf below so this shouldn't need any width/alignment set explicitly

This revision is now accepted and ready to land.Jan 19 2016, 3:00 PM

Improve formatting - the "-h" output looks much better now - and go
back to two separate printfs.

This revision now requires review to proceed.Jan 19 2016, 5:51 PM

This revision was automatically updated to reflect the committed changes.

Add "kldstat -h"; showing module sizes in hex is rather weird.
ClosedPublic
Actions