Page MenuHomeFreeBSD

riscv: improve KTR_TRAP trace entries
ClosedPublic

Authored by mhorne on Jun 17 2023, 4:59 PM.
Tags
None
Referenced Files
F168907123: D40584.id123520.diff
Sun, Aug 30, 5:06 PM
Unknown Object (File)
Sat, Aug 29, 11:20 AM
Unknown Object (File)
Thu, Aug 27, 9:11 AM
Unknown Object (File)
Wed, Aug 26, 2:22 PM
Unknown Object (File)
Wed, Aug 26, 2:22 PM
Unknown Object (File)
Wed, Aug 26, 4:48 AM
Unknown Object (File)
Wed, Aug 26, 12:52 AM
Unknown Object (File)
Tue, Aug 25, 6:11 AM
Subscribers

Details

Summary

For more informative records of exceptions, include key details such as
the exception code and stval contents. Add a new KTR_TRAP trace record
for interrupts.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/riscv/riscv/intr_machdep.c
167

KTR entries always contain a pointer to curthread (used to implement ktrdump -H), so including it here is redundant.

I wonder if the pointer to frame is ever useful?

sys/riscv/riscv/intr_machdep.c
167

Good point on curthread. For frame, probably not. It has a short lifetime and it's not like we can do much with it in ddb.

Drop curthread and trapframe arguments.

This revision is now accepted and ready to land.Jun 19 2023, 3:58 PM
This revision was automatically updated to reflect the committed changes.