Page MenuHomeFreeBSD

riscv: improve KTR_TRAP trace entries
ClosedPublic

Authored by mhorne on Jun 17 2023, 4:59 PM.
Tags
None
Referenced Files
F108649124: D40584.diff
Mon, Jan 27, 2:01 AM
Unknown Object (File)
Thu, Jan 23, 6:35 PM
Unknown Object (File)
Fri, Jan 17, 9:34 PM
Unknown Object (File)
Dec 10 2024, 5:30 PM
Unknown Object (File)
Nov 15 2024, 2:25 PM
Unknown Object (File)
Nov 15 2024, 2:23 PM
Unknown Object (File)
Nov 15 2024, 1:01 PM
Unknown Object (File)
Nov 9 2024, 3:20 PM
Subscribers

Details

Summary

For more informative records of exceptions, include key details such as
the exception code and stval contents. Add a new KTR_TRAP trace record
for interrupts.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/riscv/riscv/intr_machdep.c
167

KTR entries always contain a pointer to curthread (used to implement ktrdump -H), so including it here is redundant.

I wonder if the pointer to frame is ever useful?

sys/riscv/riscv/intr_machdep.c
167

Good point on curthread. For frame, probably not. It has a short lifetime and it's not like we can do much with it in ddb.

Drop curthread and trapframe arguments.

This revision is now accepted and ready to land.Jun 19 2023, 3:58 PM
This revision was automatically updated to reflect the committed changes.