ifconfig: Pacify a sign comparison warning in regdomain_sort.
ClosedPublic
Actions

Authored by jhb on Jun 19 2023, 5:06 PM.

Details

Reviewers

Commits

rGf19ae3633be1: ifconfig: Pacify a sign comparison warning in regdomain_sort.

Summary

Both ic_flags values are unsigned (uint32_t), so cast them to a signed
int to generate a signed result. Both ic_req values are also
unsigned, but since they are uint16_t, they are implicitly promited to
int before the subtraction.

Reported by: GCC -Wsign-compare

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 52140
Build 49031: arc lint + arc unit

Event Timeline

jhb created this revision.Jun 19 2023, 5:06 PM

Herald added a subscriber: imp. · View Herald TranscriptJun 19 2023, 5:06 PM

jhb requested review of this revision.Jun 19 2023, 5:06 PM

jhb added a parent revision: D40609: ifconfig: Consistently use uint32_t for wireless channel flags..

Harbormaster completed remote builds in B52140: Diff 123433.Jun 19 2023, 5:06 PM

I think this is fine and suspect that the actual order is not that important, but I wonder if it would be more clear to make it explicit?

something like

if (ca->ic_freq > cb->ic_freq)
        return 1;
else if (ca->ic_freq < cb->ic_freq)
        return -1;
else if (ca->ic_flags & CHAN_ALL > cb->ic_flags & CHAN_ALL)
...

(signs might be backwards)

This revision is now accepted and ready to land.Jun 19 2023, 5:17 PM

I almost did a broken out version like that, but it is a fair bit more verbose.

Closed by commit rGf19ae3633be1: ifconfig: Pacify a sign comparison warning in regdomain_sort. (authored by jhb). · Explain WhyJun 19 2023, 5:39 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGf19ae3633be1: ifconfig: Pacify a sign comparison warning in regdomain_sort..