Page MenuHomeFreeBSD

ifconfig: Pacify a sign comparison warning in regdomain_sort.
ClosedPublic

Authored by jhb on Jun 19 2023, 5:06 PM.
Tags
None
Referenced Files
F173630861: D40610.diff
Sun, Sep 27, 7:42 AM
Unknown Object (File)
Sun, Sep 20, 8:29 AM
Unknown Object (File)
Fri, Sep 11, 1:54 AM
Unknown Object (File)
Sun, Sep 6, 6:26 PM
Unknown Object (File)
Sat, Sep 5, 10:07 PM
Unknown Object (File)
Sat, Sep 5, 7:00 AM
Unknown Object (File)
Thu, Sep 3, 7:08 AM
Unknown Object (File)
Thu, Sep 3, 5:44 AM
Subscribers

Details

Summary

Both ic_flags values are unsigned (uint32_t), so cast them to a signed
int to generate a signed result. Both ic_req values are also
unsigned, but since they are uint16_t, they are implicitly promited to
int before the subtraction.

Reported by: GCC -Wsign-compare

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think this is fine and suspect that the actual order is not that important, but I wonder if it would be more clear to make it explicit?

something like

if (ca->ic_freq > cb->ic_freq)
        return 1;
else if (ca->ic_freq < cb->ic_freq)
        return -1;
else if (ca->ic_flags & CHAN_ALL > cb->ic_flags & CHAN_ALL)
...

(signs might be backwards)

This revision is now accepted and ready to land.Jun 19 2023, 5:17 PM

I almost did a broken out version like that, but it is a fair bit more verbose.