Page MenuHomeFreeBSD

hexdump: Partial lines cannot be repetitions of earlier lines.
ClosedPublic

Authored by delphij on Jun 8 2023, 7:02 AM.
Tags
None
Referenced Files
F153392206: D40471.id122969.diff
Mon, Apr 20, 9:43 PM
Unknown Object (File)
Sat, Apr 18, 10:41 AM
Unknown Object (File)
Sat, Apr 18, 4:13 AM
Unknown Object (File)
Fri, Apr 17, 7:28 PM
Unknown Object (File)
Fri, Apr 17, 8:45 AM
Unknown Object (File)
Tue, Apr 14, 12:14 PM
Unknown Object (File)
Tue, Apr 14, 2:31 AM
Unknown Object (File)
Mon, Apr 13, 8:08 AM
Subscribers

Details

Summary

When checking for repetitions of earlier lines, we compare the
first nread bytes of the line against the saved line. However,
when we read a partial line, it should never be treated as a
repetition of an earlier line, even if the first bytes match.

This change fixes a bug where a partial line could be
incorrectly identified as a repetition of an earlier line.

Reported-by: Mark Adler <madler@alumni.caltech.edu>
PR: 118723
MFC-after: 2 weeks

Test Plan

run tests

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added inline comments.
usr.bin/hexdump/display.c
274

Maybe need > 0 for style? (Even if the rest of this file isn't fully style compliant)

This revision is now accepted and ready to land.Jun 8 2023, 11:59 AM